siosm opened a new pull-request against the project: `pungi-fedora` that you are following: `` Silverblue & Kinoite: Use unified core mode ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` Hold until https://pagure.io/workstation-ostree-config/pull-request/344 is merged ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` Should be good to merge to give it a try again. CC @adamwill ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
alebastr commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` Should we switch Sericea as well? AFAIU, gitlab builds were running in unfied core mode and everything has been working so far. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` @alebastr Oh, yes, we should. Let me do that. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` CC @cverna ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` Can we please get a Rawhide and F38 compose done *before* merging this? We haven't had a compose for several days and it'd suck if this doesn't work (again) and we're stuck with old broken bits in Silverblue/Kinoite.
I can test this in openQA, but things are kind of a mess there right now (the test is failing due to the f39 toolkit container issue, there's a bunch of other failures that make it harder to see what's going on, and a billion tests have started recently because the s390x backlog cleared) so it's a bit difficult. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` I fixed one of the issue with the F38 compose yesterday: https://pagure.io/fedora-infra/ansible/pull-request/1318
I'm looking at the rpm-ostree issue now. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
kuba3351 commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` pretty please pagure-ci rebuild ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` it's also tricky to test this for f38 atm because of https://pagure.io/workstation-ostree-config/pull-request/352 . ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` we got rawhide and branched composes through now, and I think I should be in a position to do a test run with openQA today after I clean up a bunch of other messes. I'll try and do that and report back in a bit. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` So I tried this in openQA. The ostree and ostree installer builds work, the built image installs and boots OK...but doing overlays on it seems to trigger a bug. The test does `rpm-ostree install htop` and reboots, expecting to see a successful boot with htop installed. However, the system doesn't boot to a tty, it gets stuck at a screen that says "Booting `Fedora Linux blahblah`". ctrl-alt-f6 does give a working tty, at that point, but the test has already failed (it does ctrl-alt-f6 after failure to login to a console and upload logs for debugging).
This seems a slightly odd result, but it does seem reproducible, it's failed exactly the same way twice, and the same test run on prod (where I didn't patch the test to build unified core) worked OK. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` so, a bit more detail. Since that test reboots several times and does everything at a console, for convenience, it does `systemctl set-default multi-user.target` before it starts doing actual testing stuff (like the overlay). So it boots to the default graphical.target (which works fine), switches to a tty, logs in, does `systemctl set-default multi-user.target`, then does `rpm-ostree install htop`, then reboots. At that point it *should* reboot to a tty on vt1, but it does not. So it may not be the overlay that's the problem, but the `systemctl set-default multi-user.target` - that may be broken with unified core, for some reason. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` Ugh. Forget the deleted comments. I just checked and the test didn't actually run with `--unified-core` at all due to a mistake on my end. Trying again. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` F38 PR is in https://pagure.io/pungi-fedora/pull-request/1147. Both branches should be ready and working. You may merge this when you think it's ready for openQA testing. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` openQA testing doesn't require it to be merged as we actually essential parallel the process in openQA - I just edit the command to add the parameter. It just needed everything else to calm down so the tests weren't failing on other things! I've just edited the test on the staging instance and started [an F38 test](https://openqa.stg.fedoraproject.org/tests/2590612) - if that one and its deps pass, we're probably good. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` Unfortunately the overlay test failed. It's not failing on non-unified builds. I'll try and take a proper look into this on Tuesday, at the latest (monday is a holiday here). ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` OK, so I reproduced this twice, pretty sure it's accurate. When I build a Silverblue ostree+installer with `--unified-core`, it works fine, it can be installed fine...but when we run the overlay test on it, it fails.
The overlay test boots, switches to a VT, logs in as root, does `systemctl set-default multi-user.target`, does `rpm-ostree install htop` and reboots. At that point it fails: the system doesn't reach a tty on VT1 as it should, it just sticks at this screen:
https://openqa.stg.fedoraproject.org/tests/2592164#step/rpmostree_overlay/27
hitting ctrl-alt-f6 does get a tty on VT6. I suspect the problem is that changing the boot target doesn't work right, rather than actually the overlay going wrong.
This only happens when building with `--unified-core`. Same test, on the same update, without that, passes fine. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` I vaguely remember some user complaining that GDM was not being disabled. Maybe you should also explicitly disable the gdm.service unit when switching to multi-user.target? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` well, we don't have to do that on conventional RPM systems, or on non unified core ostree installs, and it would rather make the 'target' mechanism pointless if you have to go around doing all the things it's supposed to do for it? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` https://github.com/fedora-silverblue/issue-tracker/issues/401 ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` I don't know why this is happening. But I would like to point out that this is unlikely the main use case for Silverblue and package layering thus the point of working around it in the test for now. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` I don't know why this is happening. What I wanted to say is that this is unlikely the main use case for Silverblue (using multi-user.target) and should not have something to do with testing package layering thus the idea of working around it in the test for now. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` oh, I see. well, yes, we could try that as a workaround to see if the test passes, but it's a bit worrying that unified core breaks this; if we don't know why, we don't know how wide the impact is and whether it might break something else that's more likely to be important. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` OK, re-reading https://github.com/fedora-silverblue/issue-tracker/issues/401, it looks like disabling GDM would not be enough :/ ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue & Kinoite: Use unified core mode` that you are following: `` This will be for F39 ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` So I flipped this back on in openQA (which has its own ostree build code, so it's a handy place to test), and it looks like there's a bug ATM:
https://openqa.stg.fedoraproject.org/tests/2941782#step/_ostree_build/45
two errors about "Unexpected non-root owned path" show up there. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` `/usr/etc/cups/subscriptions.conf` is the offending file. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
dustymabe commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` I think this is https://github.com/coreos/rpm-ostree/issues/4437 - fixed in latest `rpm-ostree` upstream, but I don't think it is in a release yet. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` https://bodhi.fedoraproject.org/updates/FEDORA-2023-7a8817d80b > The latest rpm-ostree with the fix should now be in rawhide. Can you give the openQA tests another go? Thank ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` @adamwill Can you manually trigger a new openQA test for this change? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` OK, I've found the issue with the tty not showing up anymore with unified core. Unified core builds do not include the following:
``` [silverblue@fedora deploy]$ ll /usr/etc/systemd/system/getty.target.wants/getty@tty1.service lrwxrwxrwx. 2 root root 38 Jun 27 08:30 /usr/etc/systemd/system/getty.target.wants/getty@tty1.service -> /usr/lib/systemd/system/getty@.service ```
More verbose diff (not exhaustive as file in directories as skipped):
``` D /usr/etc/systemd/system/ctrl-alt-del.target D /usr/etc/systemd/system/dbus-org.freedesktop.oom1.service D /usr/etc/systemd/system/getty.target.wants D /usr/etc/systemd/system/multi-user.target.wants/nfs-client.target D /usr/etc/systemd/system/multi-user.target.wants/remote-fs.target D /usr/etc/systemd/system/multi-user.target.wants/systemd-oomd.service D /usr/etc/systemd/system/remote-fs.target.wants D /usr/etc/systemd/system/sockets.target.wants/systemd-journald-audit.socket D /usr/etc/systemd/system/sockets.target.wants/systemd-userdbd.socket D /usr/etc/systemd/system/sysinit.target.wants/systemd-network-generator.service D /usr/etc/systemd/system/systemd-journald.service.wants D /usr/etc/systemd/system/timers.target.wants/fstrim.timer D /usr/etc/systemd/user/basic.target.wants D /usr/etc/systemd/user/timers.target.wants ```
Will see if https://pagure.io/workstation-ostree-config/pull-request/246 fixes this issue. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` Do you still want the openQA test run now, or should I wait for the above PR? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` I'll push a fix and then you can try again. I'll ping again once I've done that. Thanks ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` I've merged https://pagure.io/workstation-ostree-config/pull-request/246 which should fix the issue surfaced in openQA when disabling GDM.
@adamwill Can you try a new openQA test with this? Thanks ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` Roger! Here's one running: https://openqa.stg.fedoraproject.org/tests/2953851#live ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` Well, that one timed out, not sure if it's related to the change or just because we wound up scheduling a whole pile of jobs in stg at once for...reasons. I'm trying again. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` Hmm. So on a retry the ISO build succeeded, as did the install test, and the rebase test...but the overlay test showed an error when trying to overlay postgresql and run `postgresql-setup`:
https://openqa.stg.fedoraproject.org/tests/2963090#step/rpmostree_overlay/47
not totally sure if that's caused by the unified core stuff or not. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` A few subsequent runs have passed, so maybe this is fine? I'll watch it for a bit longer. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` Postgresql is not using a systemd sysusers config: https://src.fedoraproject.org/rpms/postgresql/blob/rawhide/f/postgresql.spec...
I'll fix it. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` Thanks for running the test! ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` This is also likely to be https://github.com/coreos/fedora-coreos-tracker/issues/1250 ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea: Use unified core mode` that you are following: `` PR for postgresql: https://src.fedoraproject.org/rpms/postgresql/pull-request/60 ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea/Onyx: Use unified core mode` that you are following: `` @adamwill Let's merge this to get more testing? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
adamwill commented on the pull-request: `Silverblue/Kinoite/Sericea/Onyx: Use unified core mode` that you are following: `` I'd rather not merge it if the postgresql test would fail on every run, but it seems like it only failed once and has succeeded on subsequent runs, so...sure, I guess. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea/Onyx: Use unified core mode` that you are following: `` One option is to use another package for now for testing. It's unlikely that users will overlay this specific package. If we use a "less likely to fail" package (one that does not create a user) for the test then we can move forward while we fix the underlying issue. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea/Onyx: Use unified core mode` that you are following: `` https://src.fedoraproject.org/rpms/postgresql/pull-request/60 has been merged.
I don't have merge powers here. Can someone who has merge this? Thanks! ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
kevin commented on the pull-request: `Silverblue/Kinoite/Sericea/Onyx: Use unified core mode` that you are following: `` ok, here we go... ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
kevin merged a pull-request against the project: `pungi-fedora` that you are following.
Merged pull-request:
`` Silverblue/Kinoite/Sericea/Onyx: Use unified core mode ``
siosm commented on the pull-request: `Silverblue/Kinoite/Sericea/Onyx: Use unified core mode` that you are following: `` Revert in https://pagure.io/pungi-fedora/pull-request/1185 again ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/1145
rel-eng@lists.fedoraproject.org
-
Adam Williamson -
Aleksei Bavshin
-
Dusty Mabe
-
Jakub Sierżęga
-
Kevin Fenzi
-
Timothée Ravier