walters opened a new pull-request against the project: `pungi-fedora` that you are following: `` variants: Use -server productimage for cloud ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
sgallagh commented on the pull-request: `variants: Use -server productimage for cloud` that you are following: `` Shouldn't we just drop it entirely? On the off chance that someone does an ISO install, wouldn't it be confusing to get the Server branding instead of just getting the generic Fedora branding? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
walters commented on the pull-request: `variants: Use -server productimage for cloud` that you are following: `` Makes sense to me! Updated. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
sgallagh commented on the pull-request: `variants: Use -server productimage for cloud` that you are following: `` Looks good to me. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
dustymabe commented on the pull-request: `variants: Use -server productimage for cloud` that you are following: `` i think we are using this for atomic right now aren't we? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
walters commented on the pull-request: `variants: Use -server productimage for cloud` that you are following: `` For generating the cloud images yes, but that shouldn't matter right? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
dustymabe commented on the pull-request: `variants: Use -server productimage for cloud` that you are following: `` where are the defaults for partitioning defined for our atomic installer? is there a fedora-productimg-atomic? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
walters commented on the pull-request: `variants: Use -server productimage for cloud` that you are following: `` Yes, that's been used for a long time for the AH ISO. But remember partitioning for the cloud images is duplicated in the kickstarts repo. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
dustymabe commented on the pull-request: `variants: Use -server productimage for cloud` that you are following: `` yes. I'm mostly +1 to this, but will note that sometimes (especially for multi-arch) people desire to have these things defined *not in the kickstart* in the case that they are trying to use the same kickstart file for multiple architectures and also account for different requirements in partitioning. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
walters commented on the pull-request: `variants: Use -server productimage for cloud` that you are following: `` Kickstart has `%include` though right? Unless you're talking about the pre-`reqpart --add-boot` days? ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
dustymabe commented on the pull-request: `variants: Use -server productimage for cloud` that you are following: `` we removed the productimg for workstation and cloud in https://pagure.io/pungi-fedora/pull-request/518. I had forgot this was open. closing now. ``
To reply, visit the link below or just reply to this email https://pagure.io/pungi-fedora/pull-request/456
dustymabe canceled a pull-request against the project: `pungi-fedora` that you are following.
Cancelled pull-request:
`` variants: Use -server productimage for cloud ``
rel-eng@lists.fedoraproject.org
-
Colin Walters -
Dusty Mabe
-
Stephen Gallagher