On 02/29/2012 07:16 PM, Angus Salkeld wrote:
On 29/02/12 17:24 -0500, Russell Bryant wrote:
> If there are local changes, "make rpm" fails. This is because the
> tarball that gets exported doesn't have "-dirty" in it. This is one
> possible fix. The other is to change the name of the tarball.
Hi Russell
I am not sure this is right. I applied the patch and made a whitespace
change.
Now remember that libqb's version is generated at autoconf time so to
re-generate
the version (which is stored in .version) you need to:
make maintainer-clean ; ./autogen.sh ; ./configure ; make rpm
This now fails with your patch.
This is working at present (it does add the -dirty).
To make this more friendly when building from I have been meaning
to play with making the .version generation depend on .git/HEAD
Ah, ok ... I see what happened. The .version file didn't have -dirty in
it, since I hadn't made changes when I generated the configure script.
However, the $(SPEC) Makefile rule added it dynamically, so they were
out of sync.
--
Russell Bryant