#416: irc list sort order doesn't match html buglist --------------------------------------+------------------------ Reporter: tflink | Owner: tflink Type: defect | Status: new Priority: major | Milestone: Fedora 20 Component: Blocker bug tracker page | Version: Keywords: | Blocked By: Blocking: | --------------------------------------+------------------------ = bug description =
The sort order of the bugs displayed on the html buglist (milestone/XX/YY/buglist) doesn't match the sort order used when generating the irc list for meetbot. This causes some confusion and annoyance when the order of bugs discussed in the meeting is not what appears in the list that participants are looking at
= fix recommendation =
Make the sort order consistent as component,bzid for both lists
#416: irc list sort order doesn't match html buglist ---------------------------------------+----------------------- Reporter: tflink | Owner: tflink Type: defect | Status: closed Priority: major | Milestone: Fedora 20 Component: Blocker bug tracker page | Version: Resolution: fixed | Keywords: Blocked By: | Blocking: ---------------------------------------+----------------------- Changes (by mkrizek):
* status: new => closed * resolution: => fixed
Comment:
Merged in develop ([https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=develop&id=7... 7462ba2ac917381e0f1430fdf4421293fe26ddeb])
#416: irc list sort order doesn't match html buglist ---------------------------------------+----------------------- Reporter: tflink | Owner: tflink Type: defect | Status: reopened Priority: major | Milestone: Fedora 20 Component: Blocker bug tracker page | Version: Resolution: | Keywords: Blocked By: | Blocking: ---------------------------------------+----------------------- Changes (by tflink):
* status: closed => reopened * resolution: fixed =>
Comment:
There are still discrepancies between the two sorting mechanisms as reported in #439
#416: irc list sort order doesn't match html buglist ---------------------------------------+----------------------- Reporter: tflink | Owner: tflink Type: defect | Status: reopened Priority: major | Milestone: Fedora 20 Component: Blocker bug tracker page | Version: Resolution: | Keywords: Blocked By: | Blocking: ---------------------------------------+-----------------------
Comment (by mkrizek):
Both blocker list and irc list are fed with the same ordered data. The problem is that jquery table of blockers sorts the data again, although by the same key, but the result is different:
jquery table: kdelibs, kde-plasma-nm, kde-workspace
sql: kde-plasma-nm, kde-workspace, kdelibs
A solution would be to turn off default sorting in the jquery table, so the table would be fed with data sorted by a sql query:
{{{ diff --git a/blockerbugs/templates/blocker_list.html b/blockerbugs/templates/blocker_list.html index 3a08ba5..ea79d9b 100644 --- a/blockerbugs/templates/blocker_list.html +++ b/blockerbugs/templates/blocker_list.html @@ -57,7 +57,7 @@ text: '<a href="' + $(this).contents().filter('a').attr('href') + '" title="More <div class="twelve columns" id="blockertables"> {% for buglist in ['Proposed Blockers','Accepted Blockers', 'Proposed Freeze Exceptions', 'Accepted Freeze Exceptions'] %} <h2>{{ buglist }}</h2> - <table id="{{ buglist | tagify }}" cellspacing="1" class="tablesorter {sortlist: [[2,0],[1,0]]}"> + <table id="{{ buglist | tagify }}" cellspacing="1" class="tablesorter"> <thead> <tr> <th></th> }}}
The only issue with this is that if a user sorts data manually by (component,id), jquery sorts it just like listed above, but I don't think it matters that much, we need both list to be sorted same in the default state, right? What do you think?
#416: irc list sort order doesn't match html buglist ---------------------------------------+----------------------- Reporter: tflink | Owner: tflink Type: defect | Status: reopened Priority: major | Milestone: Fedora 20 Component: Blocker bug tracker page | Version: Resolution: | Keywords: Blocked By: | Blocking: ---------------------------------------+-----------------------
Comment (by kparal):
Yeah, just the default order matters.
#416: irc list sort order doesn't match html buglist ---------------------------------------+----------------------- Reporter: tflink | Owner: tflink Type: defect | Status: reopened Priority: major | Milestone: Fedora 20 Component: Blocker bug tracker page | Version: Resolution: | Keywords: Blocked By: | Blocking: ---------------------------------------+-----------------------
Comment (by tflink):
Replying to [comment:3 mkrizek]:
Both blocker list and irc list are fed with the same ordered data. The
problem is that jquery table of blockers sorts the data again, although by the same key, but the result is different:
jquery table: kdelibs, kde-plasma-nm, kde-workspace
sql: kde-plasma-nm, kde-workspace, kdelibs
A solution would be to turn off default sorting in the jquery table, so
the table would be fed with data sorted by a sql query:
If that leaves us with a functional, sortable table with a default sort order that matches the IRC list, I'm fine with it.
#416: irc list sort order doesn't match html buglist ---------------------------------------+----------------------- Reporter: tflink | Owner: tflink Type: defect | Status: closed Priority: major | Milestone: Fedora 20 Component: Blocker bug tracker page | Version: Resolution: fixed | Keywords: Blocked By: | Blocking: ---------------------------------------+----------------------- Changes (by mkrizek):
* resolution: => fixed * status: reopened => closed
Comment:
Pushed to develop [https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=develop&id=7... 7615e07ee1b9728625f0c0210c28153cf94a24e6]
qa-devel@lists.fedoraproject.org