This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/53/

On October 11th, 2013, 7:54 a.m. UTC, Martin Krizek wrote:

The diff doesn't seem right :) However, looking at https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=hotfix/t421-closedsyncfailure&id=e37129e7a5c119d43ac296a09d0f7ff9e8d42795, it looks good to me.
https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=hotfix/t421-closedsyncfailure&id=e37129e7a5c119d43ac296a09d0f7ff9e8d42795 (the comma got in the link...)

- Martin


On October 10th, 2013, 4:10 p.m. UTC, Tim Flink wrote:

Review request for blockerbugs.
By Tim Flink.

Updated Oct. 10, 2013, 4:10 p.m.

Bugs: 421
Repository: blockerbugs

Description

This is a simple fix that removes the status restriction from the bugzilla query used during bug sync

Testing

Have tested on my local machine, will deploy to staging assuming that I can get access to it

Diffs

  • testing/testfunc_update_sync.py (0b92588739c338a0706f083c2306f9b6a2f14e10)
  • testing/testfunc_bugsync.py (093115135e6df12be044a14409967c4fa0235d11)
  • testing/testfunc_bugmodel.py (b02abd4da0082cd5f9749af4cbbfe0958f3a8cbd)
  • testing/test_validators.py (PRE-CREATION)
  • testing/test_updatesync_extract_information.py (c5d3f665f475b2a16c4a948a236fc3dc807be453)
  • testing/test_spinmodel.py (PRE-CREATION)
  • testing/test_controllers.py (PRE-CREATION)
  • testing/test_bugsync_extract_information.py (d30c817097778b704e04283de9a96b812dd922ea)
  • testing/test_bugchange.py (596e922283bfd20fc0ac6811aa1eef3ef45378ea)
  • testing/test_api.py (PRE-CREATION)
  • testing/conftest.py (c30e69ac70a4753a8ef311993b0437ffb0ae0bce)
  • setup.py (7b1f26d3d52d5102672f2efc2aad7a8bbd2dbcc7)
  • sass/admin_layout.scss (PRE-CREATION)
  • requirements.txt (29abdbeb36991a6565d403889c5ed5d8d994f423)
  • init_db.sh (855df9b0a9776672d60e5546a04c1e05a4957cb4)
  • conf/blockerbugs.conf (53f717c6a5e6b39337e074da8b05d64c0cc45c5a)
  • blockerbugs/util/update_sync.py (9c46ffc7b3c2f07a73c899165044059447858a48)
  • blockerbugs/util/login.py (PRE-CREATION)
  • blockerbugs/util/koji_interface.py (PRE-CREATION)
  • blockerbugs/util/bz_interface.py (0676493ab3b8c0789087fcb75f71417c5d9c42d5)
  • blockerbugs/util/bug_sync.py (dec53ce1d5d998186cea4d63f18a835ee326542e)
  • blockerbugs/templates/update_list.html (a83dd9a422e51ea58e04ae58acd8fefe6eb1f79f)
  • blockerbugs/templates/spin_list.html (c455ff4edec0991a453a94cd0e38d959e1757672)
  • blockerbugs/templates/login.html (6023c25e3436257c1c6a1027a9b37ec21f62cee9)
  • blockerbugs/templates/layout.html (28c22872b716d7125880710db53881a73bc8cdc8)
  • blockerbugs/templates/base_nav.html (021ddb3126b4c0f30a231d8d9b32df09c669280e)
  • blockerbugs/templates/admin_layout.html (PRE-CREATION)
  • blockerbugs/templates/admin/spin_edit.html (PRE-CREATION)
  • blockerbugs/templates/admin/spin_create.html (PRE-CREATION)
  • blockerbugs/templates/admin/modify_release.html (a3bb0d95c49414ff977e82f828ffdd111e105cc6)
  • blockerbugs/templates/admin/main.html (251b1df1647e307e89bcda365422f1cee59b9a35)
  • blockerbugs/templates/admin/generate_api_key.html (PRE-CREATION)
  • blockerbugs/templates/admin/edit_userinfo.html (PRE-CREATION)
  • blockerbugs/templates/admin/admin_nav.html (34a0c2a966c265ab66166b3170f5f6d507014149)
  • blockerbugs/templates/admin/add_spin.html (be44830da436e4e87700fe940a7c5197b32d1e82)
  • blockerbugs/templates/admin/add_release.html (931001b23f52dd1b75fe0feb8d0311b76fcc907e)
  • blockerbugs/static/js/admin.js (PRE-CREATION)
  • blockerbugs/static/css/admin_layout.css (PRE-CREATION)
  • blockerbugs/models/userinfo.py (019fab2a18af3edd9a0e11e6bdd23f5bf71f94ba)
  • blockerbugs/models/user.py (a3c613621d1a0ff0d2f5a9e817e1616871c80935)
  • blockerbugs/models/update.py (cdf8739622af9871d5b1e56eef27faf9fc58768c)
  • blockerbugs/models/spin.py (b339229e25750df96984d76e15fb61992d14b2e4)
  • blockerbugs/models/settings.py (8f268f38aec6c7a4c8fbc76b1d5ce34b6dc706ca)
  • blockerbugs/models/release.py (ed2b835112e627e91c041ad07da3ba30a3dec5e0)
  • blockerbugs/models/milestone.py (bd9135b27e12c68cb4c919602f6e90f488abbb83)
  • blockerbugs/models/criterion.py (44f986796406d507978743aa211088d28c2829e8)
  • blockerbugs/models/build.py (PRE-CREATION)
  • blockerbugs/models/bug.py (c61cf22598431594f7887eb578168fe0b6f4e95c)
  • blockerbugs/models/__init__.py (9cb19b13e4691c1d0016e2c82760415f936e9f3f)
  • blockerbugs/controllers/users.py (0257c431c61fe9c1f1c502645fa3e58f54970efd)
  • blockerbugs/controllers/main.py (b72636477dd1a0a50357b262e874204f2129fe9a)
  • blockerbugs/controllers/forms.py (a16a6d26692a3a0a8c2c6ef16e4d3c886ed8b2ea)
  • blockerbugs/controllers/api/validators.py (PRE-CREATION)
  • blockerbugs/controllers/api/utils.py (PRE-CREATION)
  • blockerbugs/controllers/api/errors.py (PRE-CREATION)
  • blockerbugs/controllers/api/api.py (PRE-CREATION)
  • blockerbugs/controllers/api/__init__.py (PRE-CREATION)
  • blockerbugs/controllers/admin/spin.py (PRE-CREATION)
  • blockerbugs/controllers/admin/build.py (PRE-CREATION)
  • blockerbugs/controllers/admin/auth.py (PRE-CREATION)
  • blockerbugs/controllers/admin/__init__.py (PRE-CREATION)
  • blockerbugs/controllers/admin.py (f996367b75d6925017e9fd5015ed9bed4a5f007c)
  • blockerbugs/config.py (e68d78a6f68c526df38511fdda72e0fc01435cbd)
  • blockerbugs/cli.py (52bddd06563c6785477fa0c19271c62c099f5e33)
  • blockerbugs/__init__.py (1ae81434dc38d3342886e7de97d0cbf01ef6f050)
  • blockerbugs.spec (31ac2b847a520c0aa91dd0ac9e59de3b90807a87)
  • alembic/versions/f9e369bf00d_added_spin_type_cons.py (PRE-CREATION)
  • alembic/versions/3b0500a49ea7_added_api_key_hash_t.py (PRE-CREATION)
  • alembic/versions/1162fb4d4358_added_build_table.py (PRE-CREATION)
  • Makefile (292e7db86a207236b4bfa63ef96f5e58de797d58)
  • .gitignore (c5f8d92163a31685a35109eb4847315d9ebcd220)

View Diff