|This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/64/|
Yeah, adding a state that doesn't exist in bodhi is not the best solution but the only other thing I can think of would be to "delete" updates like bodhi does and I think that's a far worse solution since we're already aggregating information in the first place. To be honest, I don't think bodhi should allow deletion like it does (it causes problems for us and complicates some other releng/admin workflows), but that's not my call. I just had one question/concern about the code but overall, it looks good.
|blockerbugs/util/update_sync.py (Diff revision 1)|
query_updates = Update.query.all()
Shouldn't this filter the updates to grab just the ones that aren't obsolete or deleted?
- Tim Flink
On January 8th, 2014, 2:10 p.m. UTC, Martin Krizek wrote:
Review request for blockerbugs.
By Martin Krizek.
Updated Jan. 8, 2014, 2:10 p.m.