This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/45/

On September 24th, 2013, 3:44 p.m. UTC, Tim Flink wrote:

I attempted to test this on an el6 machine, got a traceback when doing sync. tb added to trac ticket

On October 1st, 2013, 1:13 p.m. UTC, Martin Krizek wrote:

Yeah, python-webassets needs to be installed, it's missing in Requires (and in epel repo, it's present in Fedora though), I filed a bug -- https://bugzilla.redhat.com/show_bug.cgi?id=1014147. Also I went ahead and created spec files for jsmin and cssmin (http://mkrizek.fedorapeople.org/) as they were easy enough to package.

On October 1st, 2013, 1:14 p.m. UTC, Martin Krizek wrote:

I can probably fix issues in python-flask-assets and python-webassets so we can have this working until it is officially fixed...

On October 1st, 2013, 2:35 p.m. UTC, Tim Flink wrote:

Not sure I understand what's required with python-webassets, that bzid shows up as invalid and I can't find anything filed against python-webassets that talks about epel. Any of the required packages would need to be in epel or at least epel-testing before we deploy to production, though. That's why builds for develop have been slow - I keep hoping that the last build will get done.

On October 2nd, 2013, 9:10 a.m. UTC, Martin Krizek wrote:

https://bugzilla.redhat.com/show_bug.cgi?id=1014147 -- there was a dot in the link above.

It's reported against python-flask-assets. So what needs to be done is to push python-webassets to epel and put it as Requires in the python-flask-assets spec file. Another thing is to send python-jsmin and python-cssmin for a package review.
I sent python-cssmin and python-jsmin for package review:
https://bugzilla.redhat.com/show_bug.cgi?id=1014601
https://bugzilla.redhat.com/show_bug.cgi?id=1014607

- Martin


On August 29th, 2013, 10:23 a.m. UTC, Martin Krizek wrote:

Review request for blockerbugs.
By Martin Krizek.

Updated Aug. 29, 2013, 10:23 a.m.

Bugs: 357
Repository: blockerbugs

Description

commit d86f88d7f9da899ffef44ad617a8a831327b7d80
Author: Martin Krizek <mkrizek@redhat.com>
Date:   Mon Aug 12 16:40:16 2013 +0200

    Improve asset management
    
    Fixes: #357


I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?

Testing

Loaded pages, seems like css and js work as expected after being minified.

Diffs

  • requirements.txt (98eab5da9306a101a41dd13708df1900e9fd1018)
  • blockerbugs/templates/layout.html (49cdbd70ef8347965dfca93971449688f9cd6cb0)
  • blockerbugs/__init__.py (b9d7a40e4e9b47624795958212025428e7788b0f)
  • blockerbugs.spec (cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce)

View Diff