This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/38/

On July 17th, 2013, 4:22 p.m. UTC, Tim Flink wrote:

blockerbugs/__init__.py (Diff revision 1)
25
    auth = FasLogin(fas)
wouldn't it make more sense to have DevLogin here since TEST is used mostly for local integration tests?
Instead of DEV or both, DEV and TEST would have DevLogin? In addition to this, though, we need an environment to test fas-bugzilla account association (we can swith to PROD to test when needed that probably).

On July 17th, 2013, 4:22 p.m. UTC, Tim Flink wrote:

blockerbugs/util/login.py (Diff revision 1)
58
        self.user = bunch.Bunch(username='developer', approved_memberships=[])
I think it would be better to have the dev user have admin privileges instead of no groups
Good point. Fixed.

On July 17th, 2013, 4:22 p.m. UTC, Tim Flink wrote:

Have you done much testing with FAS when this is enabled? I got a tb on logout when I was poking at actual login (using stg fas). If this code needs fas-openid to work, then maybe we should hold off on merging it to develop until fas-openid is working
Could you point me to the tb? I couldn't reproduce it.

- Martin


On July 18th, 2013, 9:35 a.m. UTC, Martin Krizek wrote:

Review request for blockerbugs.
By Martin Krizek.

Updated July 18, 2013, 9:35 a.m.

Repository: blockerbugs

Description

commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
Author: Martin Krizek <mkrizek@redhat.com>
Date:   Mon Jul 15 11:28:09 2013 +0200

    Use fake login only in DEV environment

commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
Author: Martin Krizek <mkrizek@redhat.com>
Date:   Thu Jul 4 11:14:40 2013 +0200

    Add developer login
    
    This patch allows a fake login when DEV or TEST is set so we don't
    access FAS server each time we log in.

TODO this will be merged with changes made in other review request dealing with fas-openid migrations.

Diffs

  • blockerbugs/util/login.py (PRE-CREATION)
  • blockerbugs/templates/layout.html (8dc6deacd5e7a71757ed2564fb224b3cd92bfad5)
  • blockerbugs/controllers/users.py (6f89a0b29143a9c09fcf25d97d875a01b9955fa4)
  • blockerbugs/controllers/main.py (a8082121576015a86c31bc76ebc17e982062a08b)
  • blockerbugs/__init__.py (798fc6ecd562d1e13fbba26f804f74e6da670120)

View Diff