This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/40/

Ship it!

Overall, what I'm seeing looks good.

Can you change the copyright dates to 2013?

I think that I'd like to see more discovery endpoints, like 'api/v0/' and 'api/v0/milestones/' etc. but that can be a later feature. I'd say merge this in and file a bug for the discovery endpoints. The copyright date doesn't need another review.

Good work, I'm glad to see this getting done!

- Tim Flink


On August 8th, 2013, 2:38 p.m. UTC, Ilgiz Islamgulov wrote:

Review request for blockerbugs.
By Ilgiz Islamgulov.

Updated Aug. 8, 2013, 2:38 p.m.

Bugs: 392
Repository: blockerbugs

Description

Add endpoints:
 - list bugs
 - list updates
 - list spins
 - create spin

Testing

Wrote test suites.
I've tested on my develop instance.

Diffs

  • testing/test_validators.py (PRE-CREATION)
  • testing/test_api.py (PRE-CREATION)
  • requirements.txt (09e0318bc189512f5d324bda8879ad74c4763f95)
  • blockerbugs/models/spin.py (99891448e78c7168d540b479ffd7ef00ce1eec1d)
  • blockerbugs/controllers/api/validators.py (PRE-CREATION)
  • blockerbugs/controllers/api/utils.py (PRE-CREATION)
  • blockerbugs/controllers/api/errors.py (PRE-CREATION)
  • blockerbugs/controllers/api/api.py (PRE-CREATION)
  • blockerbugs/controllers/api/__init__.py (PRE-CREATION)
  • blockerbugs/__init__.py (bd9973579e80fc859f3e8d22c35753fbd024c5f0)
  • blockerbugs.spec (726fa6920c67cfe36a2e544f97c9e0f16537f11e)

View Diff