This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/

As I'm looking through the template code, why not remove the "last synced with" message that's repeated in almost every page and put it at the milestone_base.html level and combine it with the cgit message?

I don't think it's as important to have the cgit or the sync message in the admin interface and it probably shouldn't be duplicated as much as it is. I can't think of a reason that we wouldn't want the "last synced" message on every public facing page.

blockerbugs/templates/index.html (Diff revision 2)
80
{% block footer %}
I assume this is associated with the layout change in the footer block - question there remains the same

blockerbugs/templates/layout.html (Diff revision 2)
144
                This is an example footer
Why remove this? I usually kept example stuff in the blocks at the layout level so that it's obvious when the block isn't being filled with any meaningful content.

blockerbugs/templates/layout.html (Diff revision 2)
150
  {% block footer_ %}
I'd rather see this combined with the existing "last synced with" footer, not done as a block in the layout or at least renamed to something more obvious than footer_

It took me a minute to realize that this was a new block and not just changing the existing footer block

- Tim


On April 22nd, 2013, 8:47 a.m. UTC, Martin Krizek wrote:

Review request for blockerbugs.
By Martin Krizek.

Updated April 22, 2013, 8:47 a.m.

Bugs: 343
Repository: blockerbugs

Description

This is maybe trivial to have a review for but two things might be discussed:
1. do we want to show the link just on index or on all pages?
2. is the wording of the link ok?

Diffs

  • blockerbugs/templates/layout.html (a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2)
  • blockerbugs/templates/index.html (088962bfcb16c3f0d163366f2235fc557e0d45dc)

View Diff