This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/55/

blockerbugs/controllers/main.py (Diff revision 1)
def display_updates_need_testing(num, milestone_name):
219
    parsed_url = urlparse.urlsplit(app.config['BUGZILLA_URL'])
I wonder if it would be better to change the configuration setting to not have the 'xmlrpc.cgi' part at the end would be a better solution.

We'd have to add it in bz_interface, but I don't really like this url munging in the controller.

Overall, looks good other than my question about url munging vs. changing how the settings are done. Thoughts?

- Tim Flink


On October 11th, 2013, 11:01 a.m. UTC, Martin Krizek wrote:

Review request for blockerbugs.
By Martin Krizek.

Updated Oct. 11, 2013, 11:01 a.m.

Bugs: t423
Repository: blockerbugs

Description

commit ddcd87dcda42b9ee17000cdac0251b0b3a7f3e28
Author: Martin Krizek <mkrizek@redhat.com>
Date:   Fri Oct 11 12:49:54 2013 +0200

    Don't use hardcoded bz url in the milestone_info template

Testing

I tested it on my local machine.

Diffs

  • blockerbugs/templates/milestone_info.html (bac8fa075ef4fd40c95fb35885951845d483b521)
  • blockerbugs/controllers/main.py (5619a834b4d613398bac2cc196a1a71457af30f2)

View Diff