This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/46/ |
On August 30th, 2013, 8:18 a.m. UTC, Martin Krizek wrote:
alembic/versions/1162fb4d4358_added_build_table.py (Diff revisions 4 - 5) 21 sa.Column('pkg_name', sa.String(), nullable=True),21 sa.Column('pkg_name', sa.Text(), nullable=True),Sorry, I wasn't probably being clear, I meant whether we should change e.g. sa.Column('version', sa.String(), nullable=True), to sa.Column('version', sa.String(50), nullable=True), and so on.
I found that koji use Text type for this columns. So as for me we should not limit a length.
- Ilgiz
On August 29th, 2013, 12:31 p.m. UTC, Ilgiz Islamgulov wrote:
Review request for blockerbugs.
By Ilgiz Islamgulov.
Updated Aug. 29, 2013, 12:31 p.m.
Repository:
blockerbugs
Description
Testing
Diffs
|