This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/18/

I think that it would be good to put the link in the global footer - I get asked where the source lives on a semi-regular basis and it might be good to make that more obvious :)

Sorry for the delay on this, should have done it a while ago.

blockerbugs/templates/index.html (Diff revision 1)
80
{% block footer %}
80
{% block footer %}
Why limit this to just the index page instead of adding it to the global footer?

blockerbugs/templates/index.html (Diff revision 1)
84
                <a class="grayed" href="http://git.fedorahosted.org/cgit/blockerbugs.git">Blocker Tracking App git repo</a>
How about something like: "This application is open source! Get the code (with embedded link to cgit) or look at development plans (with link to fedora-qa trac report 10)"?

sass/app.scss (Diff revision 1)
36
.fedora-prefooter a.grayed {
If you change the scss, you need to regenerate the css using compass as well.

sass/app.scss (Diff revision 1)
37
  color: $menuBarMainColor;
What's the advantage to greying this out instead of using the link colors that we're using elsewhere in the app?

- Tim


On March 13th, 2013, 11:21 a.m. UTC, Martin Krizek wrote:

Review request for blockerbugs.
By Martin Krizek.

Updated March 13, 2013, 11:21 a.m.

Bugs: 343
Repository: blockerbugs

Description

This is maybe trivial to have a review for but two things might be discussed:
1. do we want to show the link just on index or on all pages?
2. is the wording of the link ok?

Diffs

  • sass/app.scss (1a4369d0911b77fc411089de0b05c8d5c80e304f)
  • blockerbugs/templates/index.html (088962bfcb16c3f0d163366f2235fc557e0d45dc)

View Diff