This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/52/

blockerbugs/controllers/main.py (Diff revision 1)
def check_bz_user(user, password):
334
            userinfo = UserInfo(auth.user.username, fas_bz_form.bz_user.data)
333
            userinfo = UserInfo(g.fas_user.username, fas_bz_form.bz_user.data)
This really should be merged in develop as well as it would result in a traceback when one tries to associate his fas and bugzilla accounts. I don't see it fixed anywhere.

blockerbugs/controllers/main.py (Diff revision 1)
def propose_bug():
366
        bz_user = bugform.bz_user.data
This is just unused variable.

- Martin Krizek


On September 13th, 2013, 11:08 a.m. UTC, Martin Krizek wrote:

Review request for blockerbugs.
By Martin Krizek.

Updated Sept. 13, 2013, 11:08 a.m.

Repository: blockerbugs

Description

While going through documentation and commits since last release I found some leftovers missed in reviews.

Diffs

  • blockerbugs/controllers/main.py (a41627485a77daecc07c8d33f41dc5a17e2ebb97)
  • blockerbugs/cli.py (7151337aa1e16e571d0cf165c87c3c6f50276b90)

View Diff