This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/38/ |
blockerbugs/__init__.py (Diff revision 1) | |||
---|---|---|---|
25 | auth = FasLogin(fas) |
wouldn't it make more sense to have DevLogin here since TEST is used mostly for local integration tests?
blockerbugs/util/login.py (Diff revision 1) | |||
---|---|---|---|
58 | self.user = bunch.Bunch(username='developer', approved_memberships=[]) |
I think it would be better to have the dev user have admin privileges instead of no groups
Have you done much testing with FAS when this is enabled? I got a tb on logout when I was poking at actual login (using stg fas). If this code needs fas-openid to work, then maybe we should hold off on merging it to develop until fas-openid is working
- Tim Flink
On July 16th, 2013, 12:43 p.m. UTC, Martin Krizek wrote:
Review request for blockerbugs.
By Martin Krizek.
Updated July 16, 2013, 12:43 p.m.
Repository:
blockerbugs
Description
Diffs
|