This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/57/

On December 10th, 2013, 5:58 p.m. UTC, Tim Flink wrote:

blockerbugs/models/update.py (Diff revision 1)
class Update(db.Model):
55
                                              order_by=date_submitted.desc()))
55
                                              order_by=(status.desc(), pending.desc())))
Why is this sort order change an improvement? If an older update is pending while a newer update is stable, we'd want to show the newer update

On December 11th, 2013, 2:59 p.m. UTC, Martin Krizek wrote:

But wouldn't the older update be marked as obsolete?

On December 11th, 2013, 4:37 p.m. UTC, Tim Flink wrote:

It should be but for example, if you look at the tracking app right now, there are 2 anaconda/blivet updates - one of which has been deleted in bodhi but still shows up.

This issue was supposed to be fixed but obviously, it's not. Filed as https://phab.qadevel.cloud.fedoraproject.org/T27

I think that the problem of phantom updates are the root cause of the problem as reported, but I'll ask in bug to be sure.

On December 11th, 2013, 4:45 p.m. UTC, Tim Flink wrote:

After re-reading the bug, I stand corrected. That was a completely different issue than I was thinking about in my head.

I don't like sorting on string fields by default but I also don't see much of a way around it unless we changed the schema to use status enums instead of strings.

Go ahead and push to develop. We might want to look into changing the update status field to an enum but that's well outside the scope of this fix.
I know. This is just a part of the fix, the rest will be in https://phab.qadevel.cloud.fedoraproject.org/T21 as I mentioned in the fix description. Should have probably done it in one review, sorry for confusion.

- Martin


On December 10th, 2013, 3:54 p.m. UTC, Martin Krizek wrote:

Review request for blockerbugs.
By Martin Krizek.

Updated Dec. 10, 2013, 3:54 p.m.

Bugs: 438
Repository: blockerbugs

Description

commit 911781af9cc06e27c0a8580f07f7673c90e7329d
Author: Martin Krizek <mkrizek@redhat.com>
Date:   Tue Dec 10 16:28:52 2013 +0100

    Sort updates by (status.desc(), pending.desc())
    
    This way an update label is correctly set when multiple updates fix a
    bug. The label is chosen by the following order (the lowest one):
    
    pending testing < testing < pending stable < stable
    
    Fixes: #438

Note: the rest of the issues with displaying label is handled outside this ticket in https://phab.qadevel.cloud.fedoraproject.org/T21

Testing

Sorting seems to be working as expected.

Diffs

  • blockerbugs/models/update.py (89c083da5c91558d4dead118c67e4a1138b8cae1)
  • blockerbugs/controllers/main.py (1795ed1d717bb85e0f3d9e7e7008d68c2aae36d8)
  • blockerbugs/__init__.py (dcf6c5aadb24e6d86e95d5bb3d608b81721de47f)

View Diff