On Wed, Nov 30, 2016 at 11:10 AM, Adam Williamson <adamwill@fedoraproject.org> wrote:
On Wed, 2016-11-30 at 09:38 +0100, Josef Skladanka wrote:
> So if this is what you wanted to do (data validation), it might be a good
> idea to have that submitter middleware.

Yeah, that's really kind of the key 'job' of that layer. Remember,
we're dealing with *manual* testing here. We can't really just have a
webapp that forwards whatever the hell people manage to stuff through
its input fields into ResultsDB.

I'm not sure I'm getting it right, but the people will pass the data through a "tool" (say web app) which will provide fields to fill, and will most probably end up doing the data "sanitation" on its own. So the "frontend" could store data directly in ResultsDB, since the frontend would make the user fill all the fields. I guess I know what you are getting at ("but this is exactly the double validation!") but it is IMHO actually harder to have "generic stupid frontend" that gets the "form schema" from the middleware, shows the form, and blindly forwads data to the middleware, showing errors back, than
1) having a separate app for that, that will know the validation rules
2) it being an actual frontend on the middleware, thus reusing the "check" code internally
 
R...we need to tell the web UI 'these are the
possible scenarios for which you should prompt users to input results
at all' 
Agreed
 
(which for release validation is all the 'notice there's a new
compose, combine it with the defined release validation test cases and
expose all that info to the UI' work),
That is IMO a separate problem, but yeah.
 
and we need to take the data the
web UI generates from user input, make sure it actually matches up with
the schema we decide on for storing the results before forwarding it to
resultsdb, and tell the web UI there's a problem if it doesn't.
And this is what I have been discussing in the first part of the reply.
 
That's how I see it, anyhow. Tell me if I seem way off. :)
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net
_______________________________________________
qa-devel mailing list -- qa-devel@lists.fedoraproject.org
To unsubscribe send an email to qa-devel-leave@lists.fedoraproject.org