This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/39/ |
On July 17th, 2013, 5:19 a.m. UTC, Tim Flink wrote:
Don't python-openid-cla and python-openid-teams need to be added to the requirements.txt file? Does the python-fedora stuff really need to be added to site-packages by hand with the bump in required python fedora version? What all of that list is going to be required above and beyond the changes shown here? I'm not crazy about the idea of releasing like that but I'm suspecting that most of it would go away once a new python-fedora release is doneOn July 17th, 2013, 9:45 a.m. UTC, Martin Krizek wrote:
Exactly, this is only temporary since python-fedora containing flask_fas_openid.py hasn't been released yet (to my knowledge, at least). Sorry for not pointing that out.On July 24th, 2013, 5:59 a.m. UTC, Tim Flink wrote:
since the fas-openid stuff has been hotfixed into the infra hosts and it might be a bit before we see a new python-fedora release, let's get this into develop. I'd like to get testing on our dev host soon and am planning to hotfix the flask-fas-openid stuff into our dev host
I merged this into develop. Let's keep the review open until we test it on the dev host?
- Martin
On July 16th, 2013, 12:43 p.m. UTC, Martin Krizek wrote:
Review request for blockerbugs.
By Martin Krizek.
Updated July 16, 2013, 12:43 p.m.
Bugs:
383
Repository:
blockerbugs
Description
Testing
Diffs
|