This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/23/ |
testing/test_bugchange.py (Diff revision 2) | |||
---|---|---|---|
85 | test_bz._do_proposal = exception_raiser(Fault(50, 'not 51 exception')) |
I realize that I'm being picky here but why are you effectively monkeypatching the do_proposal method and creating a Dingus that effectively does nothing in this case? Wouldn't it be closer to actual behavior to have the Dingus throw a fault instead of swapping out the do_proposal method? Either way, I'd rather see one approach or the other - creating mock-ish objects that aren't actually used is not a good practice to get into
- Tim
On April 30th, 2013, 8:43 a.m. UTC, Martin Krizek wrote:
Review request for blockerbugs.
By Martin Krizek.
Updated April 30, 2013, 8:43 a.m.
Bugs:
372
Repository:
blockerbugs
Description
Diffs
|