> > I'm not picking on Josef here - I'm sure I've
submitted code recently
> > with lint errors, this was just the review I was looking at which
> > triggered the idea:
> > https://phab.qadevel.cloud.fedoraproject.org/D389
No worries, I'm not taking it personaly. As I commented in the D389 - the "not
compliant" parts of the code were mostly in the spirit ofthe rest of the code in the
respective files (thus actually honoring the PEP8
). Not saying that it is the best though.
> > exceptions that we'd want, I'm proposing that we
use strict PEP8 with
> > almost no exceptions.
For me, strict PEP8 is next-to-unusable, and almost always leads to code like this:
+ result = self.resultsdb.create_result(job_id=job_data['id'],
+ or None,
Hard to read, and heavily concentrated to the right edge of the 80-char mark.
In this case it would involve asking Josef to stop putting spaces between
I actually did stop doing that quite some time ago :)
First of all I'd suggest to move our codebase to strict PEP8 (or
as-strict-as-possible), so we can have see how our code looks like, when PEP8 compliant.
For starters, we could just plain use autopep8 - https://pypi.python.org/pypi/autopep8/
How about that?