blockerbugs/controllers/main.py
(Diff revision 1)
|
def get_milestone_bugs(milestone): |
76 |
updates = Update.query.join(m_alias, Update.milestones).filter(m_alias.id == milestone.id, |
76 |
updates = Update.query.join(m_alias, Update.milestones).filter( |
this query has become rather complicated, could you add a quick comment about what it's doing?
blockerbugs/controllers/main.py
(Diff revision 1)
|
def get_milestone_bugs(milestone): |
84 |
updates = Update.query.join(m_alias, Update.milestones).filter(m_alias.id == milestone.id, |
87 |
updates = Update.query.join(m_alias, Update.milestones).filter( |
A short comment on this query would also be nice
I'd rather see these two tables be collapsed into a loop instead of having the code duplication
This needs another empty <td></td> - you caught the other one, though
you need quotes around the {{ bug.summary }} or else only the first word of the title will show up in the tooltip
A couple of minor nits but overall it looks good.
- Tim Flink
On July 15th, 2013, 5:18 p.m. UTC, Ilgiz Islamgulov wrote:
Review request for blockerbugs.
By Ilgiz Islamgulov.
Updated July 15, 2013, 5:18 p.m.
Repository:
blockerbugs
Description
Add partial updates sync.
Display proposed/accepted fe/blocker bugs list associated with update on update list web page.
|
Testing
Wrote test suites.
I've tested on my develop instance.
|
Diffs
- testing/testfunc_update_sync.py (69f6bf8a459c71a9325cd633e7e33ce29354d7cd)
- testing/test_updatesync_extract_information.py (1fc701ef79a74e27cf8223b56a04d63025b6509f)
- testing/test_controllers.py (f351832ad4350fcff3d67c0137ff62892639e908)
- blockerbugs/util/update_sync.py (d664839ec1c5979dce980e7baad58154f4622e11)
- blockerbugs/util/bug_sync.py (49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3)
- blockerbugs/templates/update_list.html (a83dd9a422e51ea58e04ae58acd8fefe6eb1f79f)
- blockerbugs/models/update.py (2ee3ca7ee62bd55bbd71555c13fecfab504c4f07)
- blockerbugs/controllers/main.py (4f23e35558ac3f8ed2ccc5d897b2219e449e7277)
- blockerbugs/cli.py (694736d098b6285c53db91f91350360d478c4229)
View Diff
|