[Fedora QA] #382: Milestone Update List Generates HTTP 500 Error
by fedora-badges
#382: Milestone Update List Generates HTTP 500 Error
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: defect | Status: new
Priority: major | Milestone: Fedora 19
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+------------------------
= bug description =
Whenever the milestone updates page is loaded, there is a TB and an HTTP
500 is returned
= bug analysis =
One of the update filters in !__init!__.py still references out of date
field names for bug objects:
{{{
for bug in update.bugs:
if bug.proposed_blocker or bug.accepted_blocker:
return 'blocker'
elif bug.proposed_nth or bug.accepted_nth:
is_nth = True
}}}
bug.proposed_nth and bug.accepted_nth need to be changed to
bug.proposed_fe and bug.accepted_fe, respectively.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/382>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
10 years, 12 months
[Fedora QA] #373: Remove Mockup Warning from proposal thank you page
by fedora-badges
#373: Remove Mockup Warning from proposal thank you page
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: defect | Status: new
Priority: major | Milestone: Fedora 19
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+------------------------
= bug description =
The 'thank you' page after blocker proposal still contains a warning about
being a mockup.
= fix recommendation =
Remove the warning from that template page; it shouldn't be there any
more.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/373>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
11 years
[Fedora QA] #374: Rework Logging Mechanisms
by fedora-badges
#374: Rework Logging Mechanisms
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: major | Milestone: Fedora 19
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+------------------------
= problem =
The logs for both the blocker tracking app and the sync operation are
limited to stdout only instead of being separated out into a file.
= analysis =
The biggest problem here is recording what happens with sync - we used to
deal with it by piping the output into a file but with the shift to RPM
packaging and hosting in fedora infra, this is no longer an option.
The log messages during normal app use go to httpd's error_log but that
isn't as big of a problem.
This bug will serve as a tracker bug for all the functionality which needs
to be done in order to properly log output from sync and the blocker
tracking app.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/374>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
11 years
[Fedora QA] #377: Add log location to spec
by fedora-badges
#377: Add log location to spec
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: major | Milestone: Fedora 19
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: 374 |
--------------------------------------+------------------------
= problem =
Once logging has been implemented for sync and the blocker tracking
application, that location will need to be created at install time for
production systems.
= enhancement recommendation =
The spec file currently has no concept of the logging location - once the
production location has been determined, create that dir in the spec and
claim ownership of it.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/377>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
11 years
[Fedora QA] #376: Change logging config for app
by fedora-badges
#376: Change logging config for app
--------------------------------------+---------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: 374 |
--------------------------------------+---------------------
= problem =
The error messages from the app are only sent to stdout instead of being
directed to a log file. While this isn't a huge problem (everything will
be caught by httpd's error_log), it is not the best solution.
= enhancement recommendation =
change the logging setup so that the location is configurable (stdout,
file) and that both file and stdout could be used at the same time.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/376>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
11 years
[Fedora QA] #375: Change logging config for sync
by fedora-badges
#375: Change logging config for sync
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: enhancement | Status: new
Priority: major | Milestone: Fedora 19
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: 374 |
--------------------------------------+------------------------
= problem =
The sync process uses a different logging instance than the blocker
tracking app and is currently configured to just output to stdout instead
of logging to a file.
= enhancement recommendation =
The sync should log to a file while in production but shouldn't force
logging to a static location. The log location should be configurable
(stdout, specific file) and it should be separable from app logging.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/375>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
11 years
Review Request 20: Rework Logging Mechanisms
by Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/20/
-----------------------------------------------------------
Review request for blockerbugs.
Bugs: 374
https://fedorahosted.org/fedora-qa/ticket/374
Repository: blockerbugs
Description
-------
This is code to rework logging mechanisms for fedora-infra standards. It changed a bit from martin's original code, so I'm creating a new review request.
Diffs
-----
testing/test_updatesync_extract_information.py 1884dabb577515720c19b167a58fdb0559ba273c
testing/test_update_sync.py 1bc7b7c9d43bb0f526611aef872ace85918fc3ad
sass/app.scss 0f81cbd6d740ff7325ec080c5ccb33ecf642e0b7
runapp.py 736ec65bd25962180559d783a155c7ac1c5da285
conf/settings.py.example 7c45c785fa05c12f2c36f2ca06b99bcd41b318ce
conf/blockerbugs.cron.example ddfe8f5661854e76887cd727f187f219c80ffdae
blockerbugs/util/update_sync.py f6469da84ce9e60d65521535a07fe511fa668e1e
blockerbugs/util/bz_interface.py 7dedce924c2f96110ed98bd311b870e03e617887
blockerbugs/util/bug_sync.py 6e092aa35c04ec9a7a4b03653fddf2cef27e4ba1
blockerbugs/templates/thanks.html f5432900daae6af4d22b3e5abbbc7092df868c4a
blockerbugs/templates/layout.html a0b5ebda3ff61a3fa2647d96ef77037ed0d729d2
blockerbugs/static/img/repeater-stg.png 24c56fd10da38d7d6f8a3f684a811bc4b04b56a4
blockerbugs/static/img/blockerbugs-logo-light-stg.png b94f3891dd4726eac435c8a03c2ac0a2daafef39
blockerbugs/static/css/app.css 26e177c1e5c7cec716db5b2bcd428bb4e6a92505
blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7
blockerbugs/config.py cecca7c88ef25ee9fd81df0cd2aeb2f84030559f
blockerbugs/cli.py 0166b0fddcacc79c81f0f111317df6208c35fb12
blockerbugs/__init__.py cf068ed33799a5426e297ab9ed269c513079f726
blockerbugs.spec 012e980b5d0cf57c09bd9f993b6c21d29c5cc3d8
Diff: http://reviewboard-tflink.rhcloud.com/r/20/diff/
Testing
-------
local and dev VM testing, currently running on qa.stg.fedoraproject.org/blockerbugs/ - no issues noticed thus far
Thanks,
Tim Flink
11 years
Review Request 19: Rework Logging Mechanisms
by Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/19/
-----------------------------------------------------------
Review request for blockerbugs.
Bugs: 374
https://fedorahosted.org/fedora-qa/ticket/374
Repository: blockerbugs
Description
-------
This patch reworks logging to both, the application and syncs. Both log to stdout and to separate files, only if they are configured in config.py though.
Diffs
-----
blockerbugs/util/update_sync.py 7a6af995df3c6aa9d34a6e0ebad9b0fab2d28760
blockerbugs/util/bz_interface.py 2a7a9d128ee87bfb332426a8ada373a9a478a97a
blockerbugs/util/bug_sync.py 2e76680e1701fc3de521a2c3c9f995ae379b944f
blockerbugs/controllers/main.py 6d32e5de91900cda33f5e0342c7854adb24fc8b6
blockerbugs/config.py 2806ca0abb2fefd29505677e76fcf240149dc380
blockerbugs/cli.py 833e27585e427d4ee24f01fc5355469ce07d92ce
blockerbugs/__init__.py 7809b1fc216c764512403acb45e9e0dd836d07de
blockerbugs.spec 3f3e9567b60e2f2482cdbfbab267a2aa47f3feb5
Diff: http://reviewboard-tflink.rhcloud.com/r/19/diff/
Testing
-------
Thanks,
Martin Krizek
11 years
[Fedora QA] #380: Update Sync can't handle new packages
by fedora-badges
#380: Update Sync can't handle new packages
--------------------------------------+------------------------
Reporter: tflink | Owner: tflink
Type: defect | Status: new
Priority: blocker | Milestone: Fedora 19
Component: Blocker bug tracker page | Version:
Keywords: | Blocked By:
Blocking: |
--------------------------------------+------------------------
= bug description =
The update sync process blows up if a new package is submitted as a
blocker fix.
This does cause problems in the sync process and needs to be fixed ASAP.
= bug analysis =
The problem is that update_sync assumes there is a push time for anything
"pending stable" which is not true for new packages - they just get pushed
stable. This causes a TB like the following during sync:
{{{
Traceback (most recent call last):
File "sync_db.py", line 116, in <module>
update_sync.full_sync_updates(release)
File "/home/blockerbugs/blockerbugs/blockerbugs/util/update_sync.py",
line 180, in full_sync_updates
self.sync_bug_updates(release, bugs)
File "/home/blockerbugs/blockerbugs/blockerbugs/util/update_sync.py",
line 158, in sync_bug_updates
updates = self.search_updates([bug.bugid], release.number)
File "/home/blockerbugs/blockerbugs/blockerbugs/util/update_sync.py",
line 146, in search_updates
updateinfos.append(self.extract_information(update))
File "/home/blockerbugs/blockerbugs/blockerbugs/util/update_sync.py",
line 56, in extract_information
updateinfo['date_pushed_testing'] = date_pushed
UnboundLocalError: local variable 'date_pushed' referenced before
assignment
}}}
= fix recommendation =
The root of the problem is this code in UpdateSync.extract_information():
{{{
if update.date_pushed:
date_pushed = datetime.strptime(update.date_pushed, '%Y-%m-%d
%H:%M:%S')
}}}
and later
{{{
if update.status == 'pending':
updateinfo['pending'] = True
if update.request == 'stable':
updateinfo['status'] = 'stable'
updateinfo['date_pushed_testing'] = date_pushed
elif update.request == 'testing':
updateinfo['status'] = 'testing'
else:
updateinfo['status'] = 'undefined'
else:
updateinfo['status'] = str(update.status)
if update.status == 'testing':
updateinfo['date_pushed_testing'] = date_pushed
elif update.status == 'stable':
updateinfo['date_pushed_stable'] = date_pushed
}}}
Either date_pushed needs to be initialized to 'None' or the assignments
need to make sure that date_pushed actually exists before attempting to
access it.
--
Ticket URL: <https://fedorahosted.org/fedora-qa/ticket/380>
Fedora QA <http://fedorahosted.org/fedora-qa>
Fedora Quality Assurance
11 years