Hi Olivier,
I've applied it with several nitpicks fixed... Comments inline...
On 08/06/2012 03:35 PM, Olivier Doucet wrote:
---
classes/libvirt.php | 15 +++++++++++++++
lang/cs.php | 3 +++
lang/en.php | 3 +++
pages/info.php | 35 ++++++++++++++++++++++++++++++++++-
4 files changed, 55 insertions(+), 1 deletions(-)
diff --git a/classes/libvirt.php b/classes/libvirt.php
index d8bf892..8def902 100644
--- a/classes/libvirt.php
+++ b/classes/libvirt.php
@@ -1601,5 +1601,20 @@
$tmp = libvirt_node_get_info($this->conn);
return ($tmp) ? $tmp : $this->_set_last_error();
}
+
+ function node_get_cpu_stats() {
+ $tmp = libvirt_node_get_cpu_stats($this->conn);
+ return ($tmp) ? $tmp : $this->_set_last_error();
+ }
+
+ function node_get_mem_stats() {
+ $tmp = libvirt_node_get_mem_stats($this->conn);
+ return ($tmp) ? $tmp : $this->_set_last_error();
+ }
+
+ function connect_get_sysinfo() {
+ $tmp = libvirt_connect_get_sysinfo($this->conn);
+ return ($tmp) ? $tmp : $this->_set_last_error();
+ }
}
?>
diff --git a/lang/cs.php b/lang/cs.php
index f841658..115ef27 100644
--- a/lang/cs.php
+++ b/lang/cs.php
@@ -300,5 +300,8 @@
'password_mismatch' => 'Heslo nebylo ověřeno',
'screenshot-settings-auto-release' => 'Automaticky poslat událost
uvolnÄ›nà tlaÄÃtka myÅ¡i',
'screenshot-delay' => 'Interval byl změněn na %d sekund',
+ 'cpu_stats' => 'Node CPU stats',
+ 'mem_stats' => 'Node memory stats',
+ 'system_information' => 'System information',
That's great you created a placeholder there for Czech language version
however next time please mark them as "<cpu-stats-translation>" or
something and also put information about missing translation to the
commit message.
Also, one more thing about this: Use tabs instead of spaces and center
it the same like I'm having it to make it begin on the same position,
just next line.
Michal
--
Michal Novotny <minovotn(a)redhat.com>, RHCE, Red Hat
Virtualization | libvirt-php bindings |
php-virt-control.org