Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Spiffy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028
------- Additional Comments From steve(a)silug.org 2006-02-28 10:52 EST -------
> BTW, while talking with Ville I found that for correctness you need to
> backwhack the first XXX. My screwup. I don't know if it breaks anything,
> but you might wnat to hit it before checking in.
I wonder what the reason is for that. It seems to build fine as-is.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Spiffy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028
tibbs(a)math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs(a)math.uh.edu 2006-02-27 20:54 EST -------
I think we're set. Approved.
BTW, while talking with Ville I found that for correctness you need to backwhack
the first XXX. My screwup. I don't know if it breaks anything, but you might
wnat to hit it before checking in. The current version of this stuff is at
http://fedoraproject.org/wiki/Packaging/Perl
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Spiffy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028
------- Additional Comments From steve(a)silug.org 2006-02-27 17:10 EST -------
Given that there is a real mixin.pm, I'm checking now to see if Spiffy is a
drop-in replacement for it. If it is, we *should* be able to include a fake
mixin.pm that just does "use Spiffy". Otherwise, I guess I have to filter the
perl(mixin) dependency.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Spiffy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028
------- Additional Comments From steve(a)silug.org 2006-02-27 15:16 EST -------
I missed the perl(DB) thing. That's fixed in -3.
http://ftp.kspei.com/pub/steve/rpms/perl-Spiffy-0.30-3.src.rpm
I still *really* don't like the idea of modifying (potentially) nearly every
Kwiki package to filter out the perl(mixin) thing, especially since there's no
easy way to tell if the dependency will get picked up ahead of time.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Spiffy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028
------- Additional Comments From tibbs(a)math.uh.edu 2006-02-27 14:52 EST -------
Look, he's trying to come up with a solution that doesn't involve hacking 130
downstream packages. If you don't want to be constructive then please just
don't post.
Steve, I'm working on filtering the requires and it's really simple; you just
need six lines in %prep. Looking through what other packages in Core and Extras
do, I see that this is really very common:
cat << EOF > %{name}-req
#!/bin/sh
%{__perl_requires} $* | sed -e '/perl(mixin)/d'
EOF
%define __perl_requires %{_builddir}/%{name}-%{version}/%{name}-req
chmod +x %{__perl_requires}
(You can also reference an external script as %{SOURCE99} if you find emitting
it from the spec distasteful.)
Finally, I was hacking on the packages and noticed that Spiffy also provides
perl(DB), which I think is broken. (It overrides the super() method in the DB
package, and so it has a "package DB" statement which RPM turns into Provides:
perl(DB).) This has the capacity to break other things, so Spiffy is definitely
going to need a __perl_provides override as well:
cat <<XXX > %{name}-prov
#!/bin/sh
%{__perl_provides} $* | sed -e '/perl(DB)/d'
XXX
%define __perl_provides %{_builddir}/Spiffy-%{version}/%{name}-prov
chmod +x %{__perl_provides}
With this, things are working cleanly.
I know it's a pain to have to do this in all of the modules, but I think this is
going to be the only way to move forward. I will try to get these overrides
into the Perl template and I suggest that they get into cpanspec as well.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Spiffy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028
rc040203(a)freenet.de changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora-perl-devel-
| |list(a)redhat.com
------- Additional Comments From rc040203(a)freenet.de 2006-02-27 13:21 EST -------
(In reply to comment #19)
> http://ftp.kspei.com/pub/steve/rpms/perl-Spiffy-0.30-2.src.rpm
>
> * Mon Feb 27 2006 Steven Pritchard <steve(a)kspei.com> 0.30-2
> - Drop explicit Provides: mixin.
> - Add dummy mixin.pm.
</sigh> With all due respect, what have you been drinking? One crazyness
replacing the next?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Provides: perl(main)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183099
------- Additional Comments From ghenry(a)suretecsystems.com 2006-02-26 18:09 EST -------
Done and built.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Provides: perl(main)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183099
------- Additional Comments From ghenry(a)suretecsystems.com 2006-02-26 10:44 EST -------
Doh!
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.