Hi,
The second to last package review MUST guidelines is:
MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [24]
There's two problems with this: the reference links to footnote 23, not 24, and in any case this guideline basically says this is unecessary anyway:
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_...
Cheers, Jonathan.
Hi
The second to last package review MUST guidelines is:
MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [24]
There's two problems with this: the reference links to footnote 23, not 24,
The HTML tags for the footnotes are numbered from zero. So the link to #cite_note-23 is correct for footnote 24.
and in any case this guideline basically says this is unecessary anyway:
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_...
I think you mean this:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
According to the guidelines, EPEL packages still need the manual clean in %install. It would be good to mention this in the guidelines, for example:
"MUST: (EPEL only) At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT)."
Then again, there is a page specifically for EPEL guidelines (https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies), so perhaps this MUST item can be removed altogether?
(The footnote link for the buildroot clean item is wrong; it links to the "Prepping BuildRoot For %install" section, which was removed on 2010-04-01.)
Regards
Rich
I must have missed that MUST when I was last cleaning up that bit of the guidelines. I've removed it.
"RF" == Richard Fearn richardfearn@gmail.com writes:
RF> It would be good to mention this in the RF> guidelines, for example: RF> "MUST: (EPEL only) At the beginning of %install, each package MUST RF> run rm -rf %{buildroot} (or $RPM_BUILD_ROOT)."
Unfortunately that note be incorrect when EPEL6 is released. Plus packaging for EPEL4 and 5 packaging will never change so we could accumulate many such messy notes. Far better to put such things on the existing EPEL guidelines pages, which I believe I already did.
- J<
packaging@lists.fedoraproject.org