On Thu, 01 Feb 2018 06:52:57 +0100
Federico Bruni <fede(a)inventati.org> wrote:
Hey Michael
Many thanks for your feedback!
Il giorno gio 25 gen 2018 alle 11:57, Michael Schwendt
<mschwendt(a)gmail.com> ha scritto:
> On Thu, 25 Jan 2018 07:02:54 +0100, Federico Bruni wrote:
>
>> [...]
>
>
>> %install
>> rm -rf %{buildroot}
>
>
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
>
Yep, I know, I fixed that.
>
>> %license COPYING
>>
>> %doc README.* COPYING
>
> If including the file COPYING as a licence file already, duplicating
> it also as a separate doc file isn't necessary and should not be
> done.
I must duplicate it, since upstream is copying that file in the doc
dir:
[extractpdfmark-1.0.2]$ grep COPYING Makefile
$(srcdir)/config.h.in $(dist_doc_DATA) COPYING compile \
dist_doc_DATA = README.md README.ja.md COPYING
So if I remove it from %doc, I'll get an error:
error: Installed (but unpackaged) file(s) found:
/usr/share/doc/extractpdfmark/COPYING
Installed (but unpackaged) file(s) found:
/usr/share/doc/extractpdfmark/COPYING
Should I ask upstream to fix it and put COPYING under
/usr/share/licenses?
You could remove the copy in /usr/share/doc/extractpdfmark at the end
of %install to avoid this problem.
Paul.