Need help in fixing Rawtherapee
by Mattia Verga
Hi, I've started to work on Rawtherapee [1], which was FTB in rawhide since F24. There are some issues I'd like to discuss how to fix them.
- I've upgraded the source to latest svn from Github. From packaging guidelines, when using github for downloading a specific commit, the source url should be:
Source0: https://github.com/OWNER/%{name}/archive/%{commit0}.tar.gz#/%{name}-%{sho...
but such a link will download a source named %{name}-%{commit0}.tar.gz (with full commit in the name instead of shortcommit). Is there an error in guidelines, or am I missing something?
- There's a bug open [2] because rawtherapee bundles a font and two libraries.
The font is present in the sources, but it's not installed in the system (the file is not packaged). So, is it ok? I don't understand how the guidelines about bundling fonts [3] apply here.
About bundling libraries, rawtherapee uses a custom patched version of Klt for building, plus a heavy patched version of dcraw. Dcraw bundling has been discussed before [4] and FPC ticket was closed. In the .spec file I can see a "Provides: bundled(dcraw)". Should I manage Klt bundling like that, with a "Provides" declaration?
Thanks
Mattia
[1] https://admin.fedoraproject.org/pkgdb/package/rpms/rawtherapee/
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1248756
[3] https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fon...
[4] https://fedorahosted.org/fpc/ticket/530
7 years, 6 months
Summary/Minutes from today's FPC Meeting (2016-09-22 16:00 - 18:05 UTC)
by James Antill
======================
#fedora-meeting-1: fpc
======================
Meeting started by geppetto at 16:00:03 UTC. The full logs are
available
at
https://meetbot.fedoraproject.org/fedora-meeting-1/2016-09-22/fpc.2016-
09-22-16.00.log.html
.
Meeting summary
---------------
* Roll Call (geppetto, 16:00:03)
* LINK: https://fedoraproject.org/wiki/How_to_create_an_RPM_package
(tibbs, 16:04:58)
* Schedule (geppetto, 16:07:18)
* LINK:
https://lists.fedoraproject.org/archives/list/packaging@lists.fedor
aproject.org/message/6GBJY2656KIQHWEQHWZ57M7WYNW7E4XY/
(geppetto, 16:07:21)
* #558 Application/Library distinction and package splitting
(geppetto, 16:07:42)
* LINK: https://fedoraproject.org/wiki/User:Tibbs/AppVsLib
(geppetto, 16:08:53)
* ACTION: Application/Library distinction and package splitting, from
tibbs (+1:6, 0:0, -1:0) (geppetto, 17:10:03)
* Open Floor (geppetto, 17:12:44)
Meeting ended at 18:06:51 UTC.
Action Items
------------
* Application/Library distinction and package splitting, from tibbs
(+1:6, 0:0, -1:0)
Action Items, by person
-----------------------
* tibbs
* Application/Library distinction and package splitting, from tibbs
(+1:6, 0:0, -1:0)
* **UNASSIGNED**
* (none)
People Present (lines said)
---------------------------
* tibbs (182)
* geppetto (116)
* limburgher (35)
* Rathann (26)
* orionp (11)
* zodbot (10)
* mbooth (9)
* nirik (2)
Generated by `MeetBot`_ 0.1.4
.. _`MeetBot`: http://wiki.debian.org/MeetBot
7 years, 6 months
Summary/Minutes from today's FPC Meeting (2016-10-06 16:00 - 18:00 UTC)
by James Antill
======================
#fedora-meeting-1: fpc
======================
Meeting started by geppetto at 16:00:27 UTC. The full logs are
available
at
https://meetbot.fedoraproject.org/fedora-meeting-1/2016-10-06/fpc.2016-
10-06-16.00.log.html
.
Meeting summary
---------------
* Roll Call (geppetto, 16:00:28)
* Schedule (geppetto, 16:06:34)
* LINK:
https://lists.fedoraproject.org/archives/list/packaging@lists.fedor
aproject.org/message/FWTWDBBMVBU75XTDMC5IEI3XJR7FMYBK/
(geppetto, 16:06:37)
* #650 Alternate Python Interpreters (geppetto, 16:06:52)
* ACTION: We'll table this until FESCo has made some decisions on
what
to package (geppetto, 16:25:08)
* #651 Guidelines for new Github source format (geppetto, 16:29:37)
* ACTION: Guidelines for new Github source format (+1:6, 0:1, -1:0)
(geppetto, 16:35:13)
* #652 Strictify "Tags" and "File Permissions" sections (geppetto,
16:35:34)
* ACTION: Strictify "Tags and Sections" and "File Permissions"
sections (+1:6, 0:0, -1:0) (geppetto, 16:40:07)
* #653 Explicit approval for inclusion of fedora-rpm-
macros (geppetto,
16:40:33)
* ACTION: Explicit approval for inclusion of fedora-rpm-macros (+1:5,
0:2, -1:0) (geppetto, 17:00:32)
* #654 glibc file triggers (geppetto, 17:00:55)
* LINK: https://bugzilla.redhat.com/show_bug.cgi?id=1380878 (tibbs,
17:14:14)
* ACTION: Need to convince glibc devs. (geppetto, 17:14:49)
* Open Floor (geppetto, 17:15:04)
Meeting ended at 17:59:30 UTC.
Action Items
------------
* We'll table this until FESCo has made some decisions on what to
package
* Guidelines for new Github source format (+1:6, 0:1, -1:0)
* Strictify "Tags and Sections" and "File Permissions" sections (+1:6,
0:0, -1:0)
* Explicit approval for inclusion of fedora-rpm-macros (+1:5, 0:2,
-1:0)
* Need to convince glibc devs.
Action Items, by person
-----------------------
* **UNASSIGNED**
* We'll table this until FESCo has made some decisions on what to
package
* Guidelines for new Github source format (+1:6, 0:1, -1:0)
* Strictify "Tags and Sections" and "File Permissions" sections
(+1:6,
0:0, -1:0)
* Explicit approval for inclusion of fedora-rpm-macros (+1:5, 0:2,
-1:0)
* Need to convince glibc devs.
People Present (lines said)
---------------------------
* tibbs (169)
* geppetto (123)
* limburgher (47)
* Pharaoh_Atem (31)
* Rathann (29)
* zodbot (18)
* racor (15)
* mbooth (12)
* moto-timo (12)
* orionp (10)
* cstratak (5)
Generated by `MeetBot`_ 0.1.4
.. _`MeetBot`: http://wiki.debian.org/MeetBot
7 years, 6 months
rpmlint dir-or-file-in-var-run error help
by Jonathan Underwood
Hi,
I'm just looking at the rpmlint errors for the xpra package, and one I
am stuck on is this:
xpra.x86_64: E: dir-or-file-in-var-run /var/run/xpra
The package drops a file in /usr/lib/tmpfiles.d which causes the
creation of /var/run/xpra when needed.
The package has this in %{files}:
%ghost %dir %{_localstatedir}/run/xpra
which seems reasonable to me. So I don't really understand the rpmlint
error. I picked two packages at random, fail2ban and systemd, which
also install directories under /var/run and have those directories
listed as %ghost.
So, is the rpmlint error incorrect? Or, should these guidelines:
http://fedoraproject.org/wiki/Packaging:Tmpfiles.d
also apply to /var/run? In which case, many packages need fixing to
use %verify, I think.
Cheers,
Jonathan
7 years, 6 months