commit 0716525be54bda1679071df9fadbeed2c55eec34
Author: Till Maas <opensource(a)till.name>
Date: Sat Dec 5 11:38:39 2015 +0100
Check that review bug was created by pkg requester
pkgdb2client/admin.py | 2 +-
pkgdb2client/utils.py | 10 +++++++++-
2 files changed, 10 insertions(+), 2 deletions(-)
---
diff --git a/pkgdb2client/admin.py b/pkgdb2client/admin.py
index b23b0b0..2007e9e 100644
--- a/pkgdb2client/admin.py
+++ b/pkgdb2client/admin.py
@@ -278,7 +278,7 @@ def __handle_request_package(actionid, action):
bugid = bugid.split('=', 1)[1]
msgs = utils.check_package_creation(
- action['info'], bugid, PKGDBCLIENT)
+ action['info'], bugid, PKGDBCLIENT, action['user'])
bugid = utils.get_bug_id_from_url(action['info']['pkg_review_url'])
diff --git a/pkgdb2client/utils.py b/pkgdb2client/utils.py
index e1859dc..a164f18 100644
--- a/pkgdb2client/utils.py
+++ b/pkgdb2client/utils.py
@@ -225,7 +225,7 @@ def is_packager(user):
and fas_user['group_roles']['packager']['role_status'] ==
'approved'
-def check_package_creation(info, bugid, pkgdbclient):
+def check_package_creation(info, bugid, pkgdbclient, requester):
''' Performs a number of checks to see if a package review satisfies the
criterias to create the package on pkgdb.
@@ -267,6 +267,14 @@ def check_package_creation(info, bugid, pkgdbclient):
messages["bad"].append(
'Non-packager {0} commented on review bug'.format(user))
+ bug_creator, bug_creator_full = get_fasinfo(bug.creator)
+ if bug_creator == requester:
+ messages["good"].append("Review bug created by requester
`{0}`".format(
+ bug_creator_full))
+ else:
+ messages["bad"].append("Review bug created by `{0}` but request
"
+ "by {1}".format(bug_creator_full, requester))
+
# Check who updated the fedora-review flag to +
for flag in bug.flags:
if flag['name'] == 'fedora-review':
Show replies by date