[Bug 2314124] New: Review Request: rust-k256 - Secp256k1 elliptic curve library written in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
Bug ID: 2314124 Summary: Review Request: rust-k256 - Secp256k1 elliptic curve library written in pure Rust Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: V02460@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://v02460.fedorapeople.org/rust-k256.spec SRPM URL: https://v02460.fedorapeople.org/rust-k256-0.13.4-1.fc42.src.rpm Description: Secp256k1 elliptic curve library written in pure Rust Fedora Account System Username: v02460
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/k2 | |56 Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8060891 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED CC| |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Please only ever use `rust2rpm -p` for patching Cargo.toml.
And please add a short comment why patching out criterion is OK / necessary.
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #3 from Kai A. Hiller V02460@gmail.com --- Spec URL: https://v02460.fedorapeople.org/rust-k256.spec SRPM URL: https://v02460.fedorapeople.org/rust-k256-0.13.4-2.fc42.src.rpm
I hope this one is better. TIL about rust2rpm -p :D
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2048665 --> https://bugzilla.redhat.com/attachment.cgi?id=2048665&action=edit The .spec file difference from Copr build 8060891 to 8069679
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8069679 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- -# * Remove criterion dev-dependency. The criterion crate is used for -# micro-benchmarking, which adds no value to the packaging process. -Patch2: Strip-criterion-dependency.diff +# Manually created patch for downstream crate metadata changes +Patch: k256-fix-metadata.diff
Please don't rename this manually, it will only cause you more work long-term since you'd need to re-apply this for every new version. The file name for the Cargo.toml metadata patch and the accompanying comment are standardized across all Rust crates.
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #7 from Kai A. Hiller V02460@gmail.com --- I don’t think I fully get it:
1. Where should I add the comment that you requested then, if not in the rust2rpm.toml? 2. Regarding further updates: I tried re-running rust2rpm and rust2rpm -p, both removed the existing Patch line from the spec, so I’ll have to perform the same change again for every update.
Of course I can solve both cases with manual edits after spec re-generation, but I think you implied it’s possible to not do that manual work.
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #8 from Kai A. Hiller V02460@gmail.com --- Spec URL: https://v02460.fedorapeople.org/rust-k256.spec SRPM URL: https://v02460.fedorapeople.org/rust-k256-0.13.4-3.fc42.src.rpm
New version with standard name for diff file, still missing a comment explaining the patch.
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2052915 --> https://bugzilla.redhat.com/attachment.cgi?id=2052915&action=edit The .spec file difference from Copr build 8069679 to 8159977
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8159977 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #11 from Fabio Valentini decathorpe@gmail.com ---
- Where should I add the comment that you requested then, if not in the rust2rpm.toml?
Not sure I understand what the problem is? You can do both to preserve those changes - That's what the "package.cargo-toml-patch-comments" setting is for. The values set there are added as comments associated with the patch generated by "rust2rpm -p".
- Regarding further updates: I tried re-running rust2rpm and rust2rpm -p, both removed the existing Patch line from the spec, so I’ll have to perform the same change again for every update.
Of course I can solve both cases with manual edits after spec re-generation, but I think you implied it’s possible to not do that manual work.
It's possible to avoid *almost all* manual work when doing patches for Cargo.toml, but not *all*. Everything but re-applying Cargo.toml patch changes when running "rust2rpm -p" can be automated with rust2rpm.toml settings, and there's an RFE for automatically attempting to re-apply existing patches on re-runs too:
https://pagure.io/fedora-rust/rust2rpm/issue/83 https://pagure.io/fedora-rust/rust2rpm/issue/278
I hope I'll be able to implement something like this for rust2rpm v27.
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #12 from Kai A. Hiller V02460@gmail.com --- Spec URL: https://v02460.fedorapeople.org/rust-k256.spec SRPM URL: https://v02460.fedorapeople.org/rust-k256-0.13.4-4.fc42.src.rpm
Thanks for taking the time to clarify :)
That's what the "package.cargo-toml-patch-comments" setting is for.
This was the missing puzzle piece for me.
I hope I'll be able to implement something like this for rust2rpm v27.
Nice, you’re doing great work on rust2rpm!
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #13 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2058462 --> https://bugzilla.redhat.com/attachment.cgi?id=2058462&action=edit The .spec file difference from Copr build 8159977 to 8274697
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
--- Comment #14 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8274697 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #15 from Fabio Valentini decathorpe@gmail.com --- Thank you for the update - and sorry for the delay in getting this review done. Package looks good to me now!
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
I hope I'll be able to implement something like this for rust2rpm v27.
Nice, you’re doing great work on rust2rpm!
Thanks! BTW, rust2rpm v27 does now indeed ship with this feature.
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #16 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-k256
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-d2d4ce2232 (rust-k256-0.13.4-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-d2d4ce2232
https://bugzilla.redhat.com/show_bug.cgi?id=2314124
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2025-01-09 11:04:57
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-d2d4ce2232 (rust-k256-0.13.4-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com