https://bugzilla.redhat.com/show_bug.cgi?id=2266320

Fedora Review Service fedora-review-bot@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/k8 | |s-openapi

--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7065195 (succeeded)

Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.

https://bugzilla.redhat.com/show_bug.cgi?id=2266320

Fabio Valentini decathorpe@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review? CC| |decathorpe@gmail.com Status|NEW |ASSIGNED

--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Oof, this package contains so much duplicated identical files ... it's 35 MB of source code, of which ~23 MB are duplicate files. 😧

It looks like most of these are generated. Do you think it would be possible to de-duplicate at least some of these files? Otherwise the package is going to be gigantic compared to "regular" Rust packages.

https://bugzilla.redhat.com/show_bug.cgi?id=2266320

--- Comment #4 from Ben Beasley code@musicinmybrain.net --- (In reply to Fabio Valentini from comment #2)

Oof, this package contains so much duplicated identical files ... it's 35 MB of source code, of which ~23 MB are duplicate files. 😧

It looks like most of these are generated. Do you think it would be possible to de-duplicate at least some of these files? Otherwise the package is going to be gigantic compared to "regular" Rust packages.

May I recommend something like the following rust2rpm.toml snippet?

[requires] build = [ "hardlink", ]

[scripts.install] post = [ "# Hardlink duplicate files to greatly reduce the size of the -devel RPM", "hardlink -t %{buildroot}%{crate_instdir}", ]

Note that I didn’t review the result, only verified that it built and the hardlinking had the intended effect. The rust-k8s-openapi-devel-0.22.0-1.fc41.noarch.rpm is around 1 MiB compressed in both cases because the compression algorithm is able to exploit the redundancy in the duplicate files quite effectively, but with hardlinking the extracted size goes from about 50 MB to about 4 MB, which seems worthwhile.

https://bugzilla.redhat.com/show_bug.cgi?id=2266320

Fabio Valentini decathorpe@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(afaria@redhat.com | |)

--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Are you still interested in packaging this crate?

I have looked into packaging "podlet" for Fedora, and it would depend on this crate too. So if you're no longer going to move forward with this package, I will likely eventually submit a new review request for it.