https://bugzilla.redhat.com/show_bug.cgi?id=2315472
Bug ID: 2315472 Summary: Review Request: rust-rocket - Web framework with a focus on usability, security, extensibility, and speed Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: lukasz.wojnilowicz@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://wojnilowicz.fedorapeople.org/rust-rocket.spec SRPM URL: https://wojnilowicz.fedorapeople.org/rust-rocket-0.5.1-1.fc39.src.rpm
Description: Web framework with a focus on usability, security, extensibility, and speed.
Fedora Account System Username: wojnilowicz
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
wojnilowicz lukasz.wojnilowicz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://wojnilowicz.fedorapeople.org/rust-rocket.spec SRPM URL: https://wojnilowicz.fedorapeople.org/rust-rocket-0.5.1-1.fc39.src.rpm
rust2rpm.toml: https://wojnilowicz.fedorapeople.org/rocket/rust2rpm.toml
Description: Web framework with a focus on usability, security, extensibility, and speed.
Fedora Account System Username: wojnilowicz
I plan on packaging https://github.com/ActivityWatch/aw-server-rust and rocket package is in its requirements chain. The chain is as follows: aw-server-rust->rocket.
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
wojnilowicz lukasz.wojnilowicz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from wojnilowicz lukasz.wojnilowicz@gmail.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/ro | |cket
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8091454 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
wojnilowicz lukasz.wojnilowicz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2315611
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2315611 [Bug 2315611] Review Request: rust-ubyte - Simple, no_std-compatible library for byte units
https://bugzilla.redhat.com/show_bug.cgi?id=2315472 Bug 2315472 depends on bug 2315609, which changed state.
Bug 2315609 Summary: A request for building rust-atomic0.5 on Fedora 41 and 42 https://bugzilla.redhat.com/show_bug.cgi?id=2315609
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
--- Comment #3 from wojnilowicz lukasz.wojnilowicz@gmail.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8123129 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Status|NEW |POST
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Looks good to me! Very simple package. I would have expected worse from an entire web framework :)
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rocket
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
--- Comment #7 from wojnilowicz lukasz.wojnilowicz@gmail.com --- Thank you for the review, and yeah, this looks simple compared to the aw-server-rust that builds upon it :)
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-5e73fa28f4 (rust-rocket-0.5.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5e73fa28f4
https://bugzilla.redhat.com/show_bug.cgi?id=2315472
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-10-15 17:52:08
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-5e73fa28f4 (rust-rocket-0.5.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org