Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921264
Bug ID: 921264 Summary: Review Request: weatherspect - ASCII art simulation of current weather Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: jruzicka@redhat.com
Spec URL: http://srck.cz/pkg/weatherspect/weatherspect.spec SRPM URL: http://srck.cz/pkg/weatherspect/weatherspect-1.11-1.fc18.src.rpm Description: WeatherSpect provides a reasonably accurate simulation of what the weather looks like outside, in ASCII art. Fedora Account System Username: jruzicka
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921264
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921264
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review-
--- Comment #1 from Petr Pisar ppisar@redhat.com --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: 6186b41c7db8529eaf98864c2760837a2664cf107d1fa53620beef686c2dc1b8). Ok. Summary is Ok. Description verified from README. Ok. License verified from weatherspect. Ok. No XS code, noarch BudilArch is Ok.
There are no tests. Ok.
FATAL: The executable bundles modified Weather-Underground-3.02 (http://search.cpan.org/~mnaguib/Weather-Underground-3.02/). Please unbundle it or request Fedora Packaging Committee for an exception.
$ rpmlint weatherspect.spec ../SRPMS/weatherspect-1.11-1.fc20.src.rpm ../RPMS/noarch/weatherspect-1.11-1.fc20.noarch.rpm weatherspect.noarch: W: no-manual-page-for-binary weatherspect 2 packages and 1 specfiles checked; 0 errors, 1 warnings. rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/weatherspect-1.11-1.fc20.noarch.rpm -rwxr-xr-x 1 root root 114191 Mar 12 00:31 /usr/bin/weatherspect drwxr-xr-x 2 root root 0 Mar 14 13:09 /usr/share/doc/weatherspect-1.11 -rw-r--r-- 1 root root 3856 Mar 12 00:31 /usr/share/doc/weatherspect-1.11/CHANGES -rw-r--r-- 1 root root 2110 Mar 12 00:31 /usr/share/doc/weatherspect-1.11/README -rw-r--r-- 1 root root 18092 Mar 12 00:31 /usr/share/doc/weatherspect-1.11/gpl.txt File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/weatherspect-1.11-1.fc20.noarch.rpm | sort -k2 | uniq -c 1 perl(Curses) 1 perl(Data::Dumper) 1 perl(Fcntl) 1 perl(HTML::TokeParser) 1 perl(LWP::Simple) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 /usr/bin/env 1 perl(Term::Animation) >= 2.5 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Run-require `perl' (weatherspect:1). TODO: Replace the /usr/bin/env interpreter with `%{__perl}'.
Storable and FreezeThaw are not used. Ok.
$ rpm -q --provides -p ../RPMS/noarch/weatherspect-1.11-1.fc20.noarch.rpm | sort -k2 | uniq -c 1 weatherspect = 1.11-1.fc20 Binary provides are Ok.
$ resolvedeps f20-build ../RPMS/noarch/weatherspect-1.11-1.fc20.noarch.rpm Binary dependencies resolvable. Ok.
Package builds in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5121037). Ok.
Please resolve the bundling issues.
(BTW, it does not work for me in F20. It terminates with: $ weatherspect Exiting with SIGUse of uninitialized value in sprintf at /bin/weatherspect line 701.
Could be I said my location is `Czech Republic'? )
Resolution: NOT approved.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921264
Jakub Ruzicka jruzicka@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|medium |low Severity|medium |low
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=921264
--- Comment #2 from Jakub Ruzicka jruzicka@redhat.com --- Citing upstream on bundled WeatherUnderground:
I only bundled it because the one in CPAN doesn't work any more, and the author never responded to my emails.
This seems like a good reason for expection.
https://bugzilla.redhat.com/show_bug.cgi?id=921264
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jruzicka@redhat.com Flags| |needinfo?(jruzicka@redhat.c | |om)
--- Comment #3 from Petr Pisar ppisar@redhat.com --- Fedora allows bundling now. Are you still interested in this package?
package-review@lists.fedoraproject.org