https://bugzilla.redhat.com/show_bug.cgi?id=1360284
Rex Dieter <rdieter(a)math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #4 from Rex Dieter <rdieter(a)math.unl.edu> ---
naming: ok
license: ok
sources: ok (for now, 5.7.1 tarballs not officially released yet)
macros: ok
scriptlets: ok
follows style/conventions of other qt5- packages
1. dir
%{_qt5_plugindir}/scenegraph/
is unowned, I'd suggest changing
%{_qt5_plugindir}/scenegraph/libsoftwarecontext.so
to
%{_qt5_plugindir}/scenegraph/
in %%files list
2. If -devel pkg is *just* for cmake files, having a separate -devel pkg is
probably not needed imho. SHOULD drop -devel, and include this content in the
main pkg.
And maybe add something like
Obsoletes: qt5-qtdeclarative-render2d-devel < 5.7.1-1
Provides: qt5-qtdeclarative-render2d-devel = %{version}-%{release}
if you want
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component