Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: iguanaIR - Driver for Iguanaworks USB IR transceiver
https://bugzilla.redhat.com/show_bug.cgi?id=642773
Summary: Review Request: iguanaIR - Driver for Iguanaworks USB IR transceiver Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jarod@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://jwilson.fedorapeople.org/packaging/iguanaIR/iguanaIR.spec SRPM URL: http://jwilson.fedorapeople.org/packaging/iguanaIR/iguanaIR-1.0-0.2.pre2.svn... Description: This package provides igdaemon and igclient, the programs necessary to control the Iguanaworks USB IR transceiver.
After this package is merged into Fedora, the lirc package can then be built with iguanaIR support as well. I've tested this successfully with iguanaIR hardware provided to me by Iguanaworks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
--- Comment #1 from Jarod Wilson jarod@redhat.com 2011-01-20 17:13:59 EST --- Updated to iguanaIR 1.0.1 release:
http://jwilson.fedorapeople.org/packaging/iguanaIR/iguanaIR-1.0.1-1.el6.src....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
--- Comment #2 from Jason Tibbitts tibbs@math.uh.edu 2011-01-21 11:52:43 EST --- Builds fine; rpmlint has a few complaints: iguanaIR.x86_64: W: non-standard-uid /var/run/iguanaIR iguanair iguanaIR.x86_64: W: non-standard-gid /var/run/iguanaIR iguanair iguanaIR.x86_64: W: non-standard-uid /lib/udev/devices/iguanaIR iguanair iguanaIR.x86_64: W: non-standard-gid /lib/udev/devices/iguanaIR iguanair Obviously these are OK because the package adds a user, though there's also a group which isn't added by this package.
iguanaIR.x86_64: W: no-manual-page-for-binary igdaemon iguanaIR.x86_64: W: no-manual-page-for-binary igclient iguanaIR-devel.x86_64: W: no-documentation iguanaIR-python.x86_64: W: no-documentation iguanaIR-reflasher.noarch: W: no-documentation iguanaIR-reflasher.noarch: W: no-manual-page-for-binary iguanaIR-reflasher Manpages would be nice, but if upstream doesn't provide documentation then it's not as if you should write it.
iguanaIR.x86_64: W: incoherent-init-script-name iguanaIR ('iguanair', 'iguanaird') Just rpmlint failing to understand the name of the initscript.
iguanaIR-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/iguanaIR-1.0.1/iguanaIR_wrap.c Kind of weird for a .c file to be executable, but it just gets copied from the builddir by rpm magic. If you like you can fix it with a quick chmod in %prep.
iguanaIR-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/_iguanaIR.so _iguanaIR.so()(64bit) I'd suggest filtering this but I don't think you can use the dependency filtering stuff because this package has other compiled libraries and executables.
Unfortunately I can't seem to fetch the upstream source. Following the Source0: URL, I get redirected to http://iguanaworks.net/products.psp/releases/iguanaIR-1.0.1.tar.bz2 which redirects me again to /products.psp. I think the proper thing is:
Source0: http://iguanaworks.net/downloads/%%7Bname%7D-%%7Bversion%7D%%7B?snap%7D.tar....
You can probably get rid of the snap stuff now that there's a release, unless you intend to pull further post-release snapshots.
I note that /etc/default is an odd place for settings used by an initscript. Generally we'd put them in /etc/sysconfig.
I'm somewhat confused about the license. docs/license says everything is either LGPLv2 or GPLv2, though it also has a really troubling bit about them automatically claiming copyright over anything you "submit" to them.
However, you'd have to go through the files in the binary packages and figure out what's GPL and what's LGPL. I'm not sure it all collapses down to GPL.
Shouldn't you be creating the iguanair group as well? And is there any specific reason not to use the recommended scriptlets for setting that up?
There is no reason to call ldconfig for the -devel package; it only installs a symlink.
I note that udev is only pulled in very incidentally, I think because the scriptlets depend on initscripts. It might be useful to make that dependency more explicit.
* source files match upstream. sha256sum: 1ba324667671892b2a36aee0089d0afafd266f8b255b073b113eb5ab71f38fcc iguanaIR-1.0.1.tar.bz2 (using updated Source0: URL) * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. ? not sure about the license field * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. X final provides and requires: iguanaIR-1.0.1-1.fc15.x86_64.rpm config(iguanaIR) = 1.0.1-1.fc15 libiguanaIR.so.0()(64bit) libiguanaIR.so.0(IGUANAIR_0)(64bit) libusb.so()(64bit) libusbpre1.so()(64bit) iguanaIR = 1.0.1-1.fc15 iguanaIR(x86-64) = 1.0.1-1.fc15 = /bin/sh /sbin/chkconfig /sbin/ldconfig /sbin/service config(iguanaIR) = 1.0.1-1.fc15 libiguanaIR.so.0()(64bit) libiguanaIR.so.0(IGUANAIR_0)(64bit) libpopt.so.0()(64bit) libpopt.so.0(LIBPOPT_0)(64bit) libusb-0.1.so.4()(64bit) libusb-1.0.so.0()(64bit) lirc
iguanaIR-devel-1.0.1-1.fc15.x86_64.rpm iguanaIR-devel = 1.0.1-1.fc15 iguanaIR-devel(x86-64) = 1.0.1-1.fc15 = X /sbin/ldconfig iguanaIR = 1.0.1-1.fc15 libiguanaIR.so.0()(64bit)
iguanaIR-python-1.0.1-1.fc15.x86_64.rpm ? _iguanaIR.so()(64bit) iguanaIR-python = 1.0.1-1.fc15 iguanaIR-python(x86-64) = 1.0.1-1.fc15 = iguanaIR = 1.0.1-1.fc15 libiguanaIR.so.0()(64bit) libiguanaIR.so.0(IGUANAIR_0)(64bit) libpython2.7.so.1.0()(64bit) python >= 2.4 python(abi) = 2.7
iguanaIR-reflasher-1.0.1-1.fc15.noarch.rpm iguanaIR-reflasher = 1.0.1-1.fc15 = /usr/bin/python iguanaIR-python = 1.0.1
* no bundled libraries (that I can see). * shared libraries are installed: ldconfig is called properly (on the main package, at least). unversioned .so link is in the -devel package. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files. * scriptlets on main package are OK (ldconfig). X scriptlets on devel package are unnecessary. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * no static libraries. * no libtool .la files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
--- Comment #3 from Jarod Wilson jarod@redhat.com 2011-01-28 16:49:16 EST --- Updated package w/most of the issues addressed, hopefully.
http://jwilson.fedorapeople.org/packaging/iguanaIR/iguanaIR-1.0.1-2.el6.src....
Remaining issues: - license says GPLv2 and LPGLv2, but doesn't break down which code is under which license (though headers in many of the source files do indicate their applicable license). - private shared object Provides: still present, but yeah, can't use the filter macros here
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2011-02-04 19:25:06 EST --- I haven't heard anything more on the legal front, but I figure I can look things over anyway.
The only issue I see besides the first thing you point out above is that Requires(post): /sbin/ldconfig is missing. Sometimes I think it's funny that we add that since you can't do much without glibc installed, but them's the rules.
Regarding the filter stuff, I know that the rpm in rawhide lets us do fancier stuff. It might be worth it to investigate that, but then again it's only useful for rawhide right now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
--- Comment #5 from Jarod Wilson jarod@redhat.com 2011-02-22 14:40:09 EST --- I've got an updated spec file with the ldconfig fixup, and coincidentally, was just contacted by someone at iguanaworks, from whom I'm seeking clarification (and likely source code fixups) on the license terms. Will hold off on pushing for any further review until the license issues have been discussed with him.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
--- Comment #6 from Jason Tibbitts tibbs@math.uh.edu 2011-02-22 15:04:25 EST --- I saw something from spot about progress with the legal issues; I thought that went to this ticket but I guess not. Let me see if I can dig that up.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu 2011-02-22 15:12:03 EST --- And it's here:
http://lists.fedoraproject.org/pipermail/legal/2011-February/001554.html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
Jarod Wilson jarod@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(tibbs@math.uh.edu | |)
--- Comment #8 from Jarod Wilson jarod@redhat.com 2011-05-03 13:49:14 EDT --- Tibbs, if I just update the package with the suggested license changes (pulled from the iguanaIR svn repo), would we be good to go?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
Jarod Wilson jarod@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |616545
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642773
Alec Leamas leamas.alec@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leamas.alec@gmail.com
--- Comment #9 from Alec Leamas leamas.alec@gmail.com 2012-04-10 09:48:35 EDT --- Somewhat unhappy about rebuilding this package for each release, but otherwise very happy with it... is there any help I can provide to push things forward?
package-review@lists.fedoraproject.org