[Bug 2128486] New: Review Request: python-simple-rlp - Simple RLP (Recursive Length Prefix)
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
Bug ID: 2128486 Summary: Review Request: python-simple-rlp - Simple RLP (Recursive Length Prefix) Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: hegjon@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jonny.fedorapeople.org/python-simple-rlp.spec SRPM URL: https://jonny.fedorapeople.org/python-simple-rlp-0.1.3-1.fc36.src.rpm
Description: Encode the and decode data structures simple and fast This module is a alternative to official Ethereum pyrlp.
The pyrlp needs 5 dependencies. This alternative is write in pure python and don't have any dependencies. Recommended use for projects that don't need the Ethereum tools. If you already uses the Ethereum tools uses the pyrlp.
Features: * Very simple usage to encode and decode lists of data * Very fast to encode * Auto serialize python objects (check supported types) * Templates to convert bytes in decoded objects * No dependencies
Fedora Account System Username: jonny
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
--- Comment #1 from Jonny Heggheim hegjon@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=92232681
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
Timothy Redaelli tredaelli@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |tredaelli@redhat.com Status|NEW |ASSIGNED Flags| |fedora-review? | |needinfo?(hegjon@gmail.com) CC| |tredaelli@redhat.com Doc Type|--- |If docs needed, set a value
--- Comment #2 from Timothy Redaelli tredaelli@redhat.com --- Hi,
can you please fix the 2 reported problems:
python3-simple-rlp.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-simple-rlp/README.md
For this one you can use: sed -i 's/\r$//'
python3-simple-rlp.noarch: E: description-line-too-long The pyrlp needs 5 dependencies. This alternative is write in pure python and don't have any dependencies. Recommended use for projects that don't need the Ethereum tools. If you already uses the Ethereum tools uses the pyrlp.
For this one, just split the description line, since it's too long
Thank you
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(hegjon@gmail.com) |
--- Comment #3 from Jonny Heggheim hegjon@gmail.com --- (In reply to Timothy Redaelli from comment #2)
Hi,
can you please fix the 2 reported problems:
python3-simple-rlp.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-simple-rlp/README.md
For this one you can use: sed -i 's/\r$//'
python3-simple-rlp.noarch: E: description-line-too-long The pyrlp needs 5 dependencies. This alternative is write in pure python and don't have any dependencies. Recommended use for projects that don't need the Ethereum tools. If you already uses the Ethereum tools uses the pyrlp.
For this one, just split the description line, since it's too long
Thank you
Thanks, I added the sed command in %prep and splited the %description line into shorter lines.
Updated srpm and spec file (same URLs)
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tredaelli@redhat. | |com)
--- Comment #4 from Jonny Heggheim hegjon@gmail.com --- Would you have time to have a look at your requested changes?
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
Timothy Redaelli tredaelli@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(tredaelli@redhat. | |com) | Status|ASSIGNED |POST
--- Comment #5 from Timothy Redaelli tredaelli@redhat.com --- LGTM
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
--- Comment #6 from Jonny Heggheim hegjon@gmail.com --- Thanks for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
--- Comment #7 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-simple-rlp
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-3a55448bc0 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3a55448bc0
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c99a6df9b1 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c99a6df9b1
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-3a55448bc0 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3a55448bc0 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3a55448bc0
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c99a6df9b1 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c99a6df9b1 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c99a6df9b1
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2022-12-05 22:32:38
--- Comment #12 from Jonny Heggheim hegjon@gmail.com --- Updated for Fedora 36 and later
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|CURRENTRELEASE |ERRATA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c99a6df9b1 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2128486
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-3a55448bc0 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com