Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541694

--- Comment #1 from Christof Damian christof@damian.net 2009-11-26 13:35:05 EDT --- This is a dependency for a new version of php-phpunit-phploc

rpmlint output: php-phpunit-File-Iterator.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541694

Remi Collet fedora@famillecollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com

--- Comment #3 from Remi Collet fedora@famillecollet.com 2009-11-28 02:55:40 EDT ---

BuildRequires: php-pear >= 1.7.2

This is not correct because we have php-pear-4.3.9 in EL4

Shoud be BuildRequires: php-pear >= 1:1.7.2 or BuildRequires: php-pear(PEAR) >= 1.7.2

+

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541694

--- Comment #5 from Christof Damian christof@damian.net 2009-11-28 04:03:09 EDT --- (In reply to comment #3)

...

BuildRequires: php-pear >= 1.7.2

This is not correct because we have php-pear-4.3.9 in EL4

Shoud be BuildRequires: php-pear >= 1:1.7.2 or BuildRequires: php-pear(PEAR) >= 1.7.2

(In reply to comment #4)

Please also requires php-common rather than php to avoid dependecy on httpd

I fixed both of these. New files:

Spec URL: http://rpms.damian.net/SPECS/php-phpunit-File-Iterator.spec SRPM URL: http://rpms.damian.net/SRPMS/php-phpunit-File-Iterator-1.1.0-3.fc12.src.rpm

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541694

--- Comment #6 from Remi Collet fedora@famillecollet.com 2009-11-28 09:03:19 EDT --- REVIEW:

+ rpmlint is ok php-phpunit-File-Iterator.src: I: checking php-phpunit-File-Iterator.noarch: I: checking php-phpunit-File-Iterator.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines + License ok : BSD + License is upstream + spec in english and legible + no license file in sources + sources match the upstream sources 8bd52abf03f3c8f86d296b4ee5d3d39d File_Iterator-1.1.0.tgz + Source URL ok + build on F12.x86_64 + BuildRequires (php-pear >= 1:1.7.2, php-channel(pear.phpunit.de)) ok + no locale + no .so - DONT own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + no documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in koji (dist-f13) http://koji.fedoraproject.org/koji/taskinfo?taskID=1835237 + no test suite + scriptlets ok + Final Requires ok /usr/bin/pear php-channel(pear.phpunit.de) php-common >= 5.2.0 + Final Provides ok php-pear(pear.phpunit.de/File_Iterator) = 1.1.0 php-phpunit-File-Iterator = 1.1.0-3.fc8

Changing minimal dependency for PEAR seems acceptable as it's only for "installer"

MUST fix: - own /usr/share/pear/File

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541694

Remi Collet fedora@famillecollet.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #8 from Remi Collet fedora@famillecollet.com 2009-11-30 11:36:37 EDT --- All must fixed

***** APPROVED *****

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541694

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+

--- Comment #10 from Kevin Fenzi kevin@tummy.com 2009-12-03 01:26:23 EDT --- cvs done.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541694

--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-12-04 18:56:49 EDT --- php-phpunit-File-Iterator-1.1.0-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.