Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

Steve Traylen steve.traylen@cern.ch changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |steve.traylen@cern.ch QAContact|extras-qa@fedoraproject.org |steve.traylen@cern.ch Flag| |fedora-review?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

--- Comment #2 from Steve Traylen steve.traylen@cern.ch 2011-08-18 15:45:00 EDT --- 1) You have a few mentions of '/etc/init.d' which should be /etc/rc.d/init.d and in fact should be %{_initrddir}. You have to set this if you are targeting EPEL5 as well (yes please).

2) Given that mcollective and mcollective-client requires mcollective-common I see no need to duplicate the

Requires: ruby Requires: rubygems Requires: rubygem-stomp

on these packages.

3) Version 1.3.0 looks to be the newest version.

4) You have Requires: rubygem(stomp) and Requires: rubygem-stomp in some places. See ruby guidelines:

5) The ruby(abi) requires should be defined. http://fedoraproject.org/wiki/Packaging:Ruby

6) Notice how ruby_sitelib is defined here. http://fedoraproject.org/wiki/Packaging:Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

--- Comment #4 from Jeffrey C. Ollie jeff@ocjtech.us 2011-11-21 08:58:22 EST --- Spec URL: http://jcollie.fedorapeople.org/mcollective.spec SRPM URL: http://jcollie.fedorapeople.org/mcollective-1.3.1-2.fc16.src.rpm

Yes, I will be maintaining branches for EPEL in addition to Fedora.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

Steve Traylen steve.traylen@cern.ch changed:

What |Removed |Added ---------------------------------------------------------------------------- QAContact|steve.traylen@cern.ch |extras-qa@fedoraproject.org

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

--- Comment #7 from Steve Traylen steve.traylen@cern.ch 2011-12-05 14:16:12 EST --- +:ok, =:needs attention, -:needs fixing

MUST Items: [=] MUST: rpmlint must be run on every package.

$ rpmlint ./mcollective.spec ./mcollective.spec:164: E: files-attr-not-set ./mcollective.spec:173: E: files-attr-not-set ./mcollective.spec:181: E: files-attr-not-set 0 packages and 1 specfiles checked; 3 errors, 0 warnings.

Can you swap the lines: %doc COPYING %defattr(-,root,root,-)

to get rid of this.

$ rpmlint ./*.rpm

This is still present: mcollective.noarch: W: service-default-enabled /etc/rc.d/init.d/mcollective

See

$ rpmlint -I service-default-enabled

[+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name} [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. ASL 2.0 [+] MUST: The License field in the package spec file must match the actual license. Licensing is very clear. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. COPYING [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ md5sum mcollective-1.3.1.tgz ../SOURCES/mcollective-1.3.1.tgz c63901134ea66973702720861f020d3a mcollective-1.3.1.tgz c63901134ea66973702720861f020d3a ../SOURCES/mcollective-1.3.1.tgz

[+] MUST: The package must successfully compile and build into binary rpms on at least one supported architecture.. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [] MUST: The package must contain code, or permissible content. This is described in detail in the code vs. content section of Packaging Guidelines. [+] MUST: Large documentation files should go in a doc subpackage. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items: [+] SHOULD: The reviewer should test that the package builds in mock.

[to be checked.] SHOULD: The reviewer should test that the package functions as described. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [=] SHOULD: Packages should try to preserve timestamps of original installed files.

You missed a few '-p' on the last installs:

%{__install} -m0640 etc/server.cfg.dist %{buildroot}/etc/mcollective/server.cfg %{__install} -m0640 etc/client.cfg.dist %{buildroot}/etc/mcollective/client.cfg %{__install} -m0644 etc/facts.yaml.dist %{buildroot}/etc/mcollective/facts.yaml %{__install} -m0644 etc/rpc-help.erb %{buildroot}/etc/mcollective/rpc-help.erb

Looking good generally, let me have a go at installing and running it.

Steve.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

--- Comment #9 from Jeffrey C. Ollie jeff@ocjtech.us 2011-12-05 16:17:20 EST --- Spec URL: http://jcollie.fedorapeople.org/mcollective.spec SRPM URL: http://jcollie.fedorapeople.org/mcollective-1.3.1-4.fc16.src.rpm

OK, this should take care of the remaining rpmlint problems. mcollective manages it's logfile itself. See the documentation for the keeplogs and max_log_size parameters:

http://docs.puppetlabs.com/mcollective/reference/basic/configuration.html

I'll work on getting a package review of systemu up ASAP.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

--- Comment #10 from Jeffrey C. Ollie jeff@ocjtech.us 2011-12-05 16:50:46 EST --- systemu review request here:

https://bugzilla.redhat.com/show_bug.cgi?id=760357

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

--- Comment #12 from Jeffrey C. Ollie jeff@ocjtech.us 2011-12-06 16:35:45 EST --- (In reply to comment #11)

Could you please replace the Perl call with either sed, awk or some nice ruby oneliner [1]? I understand that Perl is just tool to do the job and this may sound ridiculous, but:

Actually, I've switched to using a pure patch to do the work...

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

--- Comment #14 from Vít Ondruch vondruch@redhat.com 2011-12-07 07:29:16 EST --- Nice try, thank you. Unfortunately I can see another two perl lines still present in %build section.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

Steve Traylen steve.traylen@cern.ch changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #16 from Steve Traylen steve.traylen@cern.ch 2011-12-09 08:57:24 EST --- All comments were addressed,

I also cringed at the %perl statements in there but could not give a reason for them to go. I'm glad they have :-)

APPROVED

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

Jeffrey C. Ollie jeff@ocjtech.us changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #18 from Jeffrey C. Ollie jeff@ocjtech.us 2011-12-09 10:20:35 EST --- New Package SCM Request ======================= Package Name: mcollective Short Description: A framework to build server orchestration or parallel job execution systems Owners: jcollie Branches: f16 f15 el6 el5 InitialCC:

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

--- Comment #21 from Fedora Update System updates@fedoraproject.org 2011-12-09 15:57:04 EST --- mcollective-1.3.1-6.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mcollective-1.3.1-6.el5

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #23 from Fedora Update System updates@fedoraproject.org 2011-12-10 16:23:36 EST --- Package mcollective-1.3.1-6.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing mcollective-1.3.1-6.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2011-5182/mcollective-1.... then log in and leave karma (feedback).

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698405

--- Comment #25 from Fedora Update System updates@fedoraproject.org 2011-12-16 11:04:43 EST --- mcollective-1.3.1-6.fc16,rubygem-systemu-2.4.1-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/mcollective-1.3.1-6.fc16,rubygem-sys...