https://bugzilla.redhat.com/show_bug.cgi?id=2145116
Bug ID: 2145116 Summary: Review Request: rust-serde-sarif - Serde serialization for SARIF files Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jamacku@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/jamacku/rust-serde-sarif/... SRPM URL: https://download.copr.fedorainfracloud.org/results/jamacku/rust-serde-sarif/... Description: This package contains library source intended for building other packages which use the "serde-sarif" crate Fedora Account System Username: jamacku
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
Jan Macku jamacku@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2064470
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2064470 [Bug 2064470] rust-derive_builder-0.11.2 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2145116 Bug 2145116 depends on bug 2064470, which changed state.
Bug 2064470 Summary: rust-derive_builder-0.12.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2064470
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |h-k-81@hotmail.com Flags| |needinfo?(jamacku@redhat.co | |m)
--- Comment #1 from blinxen h-k-81@hotmail.com --- Do you still need this package? The provided URLs result in a 404.
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
Jan Macku jamacku@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jamacku@redhat.co | |m) |
--- Comment #2 from Jan Macku jamacku@redhat.com --- @(In reply to blinxen from comment #1)
Do you still need this package? The provided URLs result in a 404.
Yes, I still want to package this crate into Fedora. Thanks for letting me know. I'll update the links as soon as possible.
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jamacku@redhat.co | |m) CC| |michel@michel-slm.name
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- Still 404 by the way
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
Jan Macku jamacku@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jamacku@redhat.co | |m) |
--- Comment #4 from Jan Macku jamacku@redhat.com --- I'm sorry that it is taking that long. I checked the upstream, and they are using some outdated dependencies. So I cannot provide a scratch build for review at the moment.
Problem: nothing provides requested (crate(prettyplease/default) >= 0.1.24 with crate(prettyplease/default) < 0.2.0~)
I have noticed upstream, I'll try to provide a review build as soon as possible.
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
--- Comment #5 from Jan Macku jamacku@redhat.com --- I was able to build the package with the latest upstream release finally. I'm sorry for the delay.
The links should be up to date and ready to review.
Thank you.
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |decathorpe@gmail.com Status|NEW |POST Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Thanks for the update! Looks good to me. And sorry this has taken so long!
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
--- Comment #7 from Jan Macku jamacku@redhat.com --- No worries. Thank you for the quick review Fabio.
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serde-sarif
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-7c01d1292f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7c01d1292f
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-b9e6284e97 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b9e6284e97
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-7c01d1292f has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7c01d1292f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7c01d1292f
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-b9e6284e97 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b9e6284e97` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b9e6284e97
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2023-08-09 01:31:06
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-7c01d1292f has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2145116
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-b9e6284e97 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org