https://bugzilla.redhat.com/show_bug.cgi?id=1520024
Bug ID: 1520024 Summary: Review Request: netatalk - Open Source Apple Filing Protocol (AFP) File Server Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: ryan@breaker.rocks QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://breaker.rocks/netatalk.spec SRPM URL: http://breaker.rocks/netatalk-3.1.11-1.fc28.src.rpm Description: Netatalk is a freely-available Open Source AFP file server. A *NIX/*BSD system running Netatalk is capable of serving many Macintosh clients simultaneously as an AppleShare file server. Fedora Account System Username: ryanbreaker
This is my first package contribution to any Linux distribution and I also currently seek a sponsor. This package was previously in the Fedora repositories but was later orphaned and abandoned in 2016 (https://src.fedoraproject.org/rpms/netatalk). This first package of mine is an attempt to revive it to its latest version as well as maintain it.
This revision is much like the orphaned version but with Patch1 removed, which was worked into the upstream of the project itself, as well as the sources updated to the most recent version of 3.1.11 from the previous 3.1.7.
Except for arch s390x, which I am still troubleshooting and may require assistance with, here is a successful scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23489939
I have also tested this package and its service in my own environment successfully.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1520024
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review. I'll also be sponsoring this packager,
https://bugzilla.redhat.com/show_bug.cgi?id=1520024
--- Comment #2 from Ryan Breaker ryan@breaker.rocks --- (In reply to Neal Gompa from comment #1)
Taking this review. I'll also be sponsoring this packager,
Thanks!
I did notice the compiled binary RPM has some rpmlint issues which I'm still trying to figure out, and may need some help with.
For example:
* E: missing-call-to-setgroups-before-setuid /usr/sbin/afpd * E: missing-call-to-setgroups-before-setuid /usr/sbin/cnid_dbd
Looking through the source for each of these however, the order of the function calls appear to be correct (https://wiki.sei.cmu.edu/confluence/display/c/POS36-C.+Observe+correct+revoc...).
I'm still new to RPMs so thank you for your patience.
https://bugzilla.redhat.com/show_bug.cgi?id=1520024
Alan Hamilton alanh@arizonaroads.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alanh@arizonaroads.com
--- Comment #3 from Alan Hamilton alanh@arizonaroads.com --- From looking at what rpmlint is doing, it's dumping the external symbols from the executable and assuming that the calls are in the order that they appear in the symbol table. So it's expecting setgid to come before setuid, and it's not in this build.
However, I'm not sure that's a valid assumption on rpmlint's part. As long as the code looks okay, I'd say it's safe to call it a false positive.
Some of the others are easy. The dir-or-file-in-var-lock error can be fixed by running configure with --with-lockfile=/run/netatalk to move the file to the standard run directory.The %ghost directive should be changed to /run/netatalk
I've taken a crack at fixing some of the other issues in the spec file, notably moving /var/lock/netatalk to /run/netatalk, and removing the ownership of /var/lib.
https://bugzilla.redhat.com/show_bug.cgi?id=1520024
--- Comment #4 from Alan Hamilton alanh@arizonaroads.com --- Created attachment 1380830 --> https://bugzilla.redhat.com/attachment.cgi?id=1380830&action=edit Updated netatalk.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1520024
HAT hat@fa2.so-net.ne.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hat@fa2.so-net.ne.jp
--- Comment #5 from HAT hat@fa2.so-net.ne.jp --- To: Ryan Breaker
your spec file:
# Ghost lock dir. mkdir -p %{buildroot}/var/lock/netatalk
%ghost %dir /var/lock/netatalk
The /var/lock/netatalk is file, not directory.
To: Alan Hamilton
your spec file:
# Ghost lock dir. mkdir -p %{buildroot}/run/netatalk
%ghost %dir /run/netatalk
The /run/netatalk is file, not directory.
https://bugzilla.redhat.com/show_bug.cgi?id=1520024
--- Comment #6 from HAT hat@fa2.so-net.ne.jp --- http://netatalk.sourceforge.net/wiki/index.php/Netatalk_3.1.11_SRPM_for_Fedo... Spec URL: http://www003.upp.so-net.ne.jp/hat/files/netatalk.spec SRPM URL: http://www003.upp.so-net.ne.jp/hat/files/netatalk-3.1.11-1.2.fc29.src.rpm
I updated Ryan Breaker's SRPM.
pam_ck_connector.so isn't always installed https://bugzilla.redhat.com/show_bug.cgi?id=1520024
require dconf package https://bugzilla.redhat.com/show_bug.cgi?id=1248157
require perl-IO-Socket-INET6 for asip-status.pl script
define with_ldap https://bugzilla.redhat.com/show_bug.cgi?id=1249403
The UAM path should be netatalk, not atalk https://bugzilla.redhat.com/show_bug.cgi?id=1249404
fix multilib conflict of tracker-devel https://sourceforge.net/p/netatalk/bugs/637/
Support EL6.
Support Fedora 28 and later.
However, many problems of rpmlint aren't being corrected.
https://bugzilla.redhat.com/show_bug.cgi?id=1520024
Steven Schlansker stevenschlansker@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |stevenschlansker@gmail.com
--- Comment #7 from Steven Schlansker stevenschlansker@gmail.com --- I have been running the discontinued fc26 netatalk, which I uninstalled. I then upgraded the host f27 -> f28. HAT, I was not able to download your SRPM (404) but I did build 3.1.11-1.3.fc28 based on your specfile. I installed it, restored the afp.conf.rpmsave so I had configuration, and am working through a Time Machine backup. Thanks to all of you for picking this package up, looking forward to seeing it in the repos soon.
https://bugzilla.redhat.com/show_bug.cgi?id=1520024
--- Comment #8 from HAT hat@fa2.so-net.ne.jp --- See http://netatalk.sourceforge.net/wiki/index.php/Netatalk_3.1.11_SRPM_for_Fedo...
Spec URL: http://www003.upp.so-net.ne.jp/hat/files/netatalk.spec SRPM URL: http://www003.upp.so-net.ne.jp/hat/files/netatalk-3.1.11-1.3.fc29.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1520024
--- Comment #9 from Andrew Bauer zonexpertconsulting@outlook.com --- Most of the issues identified in this review appear to have been fixed by HAT, who appears to be upstream developer. Thanks, HAT.
Is the original author still interested in completing this review? I am not in the sponsor group, but I can help finish the review if that is what is needed.
If not, can this review be closed so that I can create a new review request?
package-review@lists.fedoraproject.org