[Bug 1416705] New: Review Request: python-kivy - Kivy - Multimedia / Multitouch framework in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
Bug ID: 1416705 Summary: Review Request: python-kivy - Kivy - Multimedia / Multitouch framework in Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@alice.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-kivy.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-kivy-1.9.1-1.fc25.src....
Description: Kivy is an open source, cross-platform [Python](https://www.python.org) framework for the development of applications that make use of innovative, multi-touch user interfaces. The aim is to allow for quick and easy interaction design and rapid prototyping whilst making your code reusable and deployable.
Kivy is written in Python and [Cython](http://cython.org/), based on OpenGL ES 2, supports various input devices and has an extensive widget library. With the same codebase, you can target Windows, OS X, Linux, Android and iOS. All Kivy widgets are built with multitouch support.
Kivy is MIT licensed, actively developed by a great community and is supported by many projects managed by the [Kivy Organization](http://kivy.org/#organization).
Fedora Account System Username: martinkg
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
--- Comment #1 from MartinKG mgansser@alice.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-kivy.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-kivy-1.9.1-2.fc25.src....
%changelog * Sun Jan 29 2017 Martin Gansser martinkg@fedoraproject.org - 1.9.1-2 - added BuildArch noarch to doc subpackage - adapt architecture and Python version for html build - add BR python3-sphinx
rpmlint -i python-kivy.spec /home/martin/rpmbuild/SRPMS/python-kivy-1.9.1-2.fc25.src.rpm /home/martin/rpmbuild/RPMS/x86_64/python2-kivy-1.9.1-2.fc25.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/python3-kivy-1.9.1-2.fc25.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/python2-kivy-devel-1.9.1-2.fc25.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/python3-kivy-devel-1.9.1-2.fc25.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/python-kivy-examples-1.9.1-2.fc25.x86_64.rpm /home/martin/rpmbuild/RPMS/noarch/python-kivy-doc-1.9.1-2.fc25.noarch.rpm /home/martin/rpmbuild/RPMS/x86_64/python-kivy-debuginfo-1.9.1-2.fc25.x86_64.rpm python-kivy.src: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check.
python2-kivy.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check.
python2-kivy.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/kivy/tools/highlight/kivy-mode.el The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
python2-kivy.x86_64: W: uncompressed-zip /usr/lib64/python2.7/site-packages/kivy/tests/unicode_files.zip The zip file is not compressed.
python3-kivy.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check.
python3-kivy.x86_64: E: incorrect-fsf-address /usr/lib64/python3.5/site-packages/kivy/tools/highlight/kivy-mode.el The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF.
python3-kivy.x86_64: W: uncompressed-zip /usr/lib64/python3.5/site-packages/kivy/tests/unicode_files.zip The zip file is not compressed.
python2-kivy-devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share.
python2-kivy-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
python3-kivy-devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share.
python3-kivy-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
python-kivy-examples.x86_64: W: spelling-error Summary(en_US) multitouch -> multitudinous The value of this tag appears to be misspelled. Please double-check.
python-kivy-examples.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check.
python-kivy-examples.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
python-kivy-doc.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check.
8 packages and 1 specfiles checked; 2 errors, 13 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
Randy Barlow randy@electronsweatshop.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |randy@electronsweatshop.com Assignee|nobody@fedoraproject.org |randy@electronsweatshop.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
Randy Barlow randy@electronsweatshop.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mgansser@alice.de Flags| |needinfo?(mgansser@alice.de | |)
--- Comment #2 from Randy Barlow randy@electronsweatshop.com --- Hello!
There are a few issues that will need to be fixed for approval:
* The package can't be installed. dnf reports:
- nothing provides python-kivy(x86-64) = 1.9.1-2.fc27 needed by python-kivy-doc-1.9.1-2.fc27.noarch - nothing provides python-kivy(x86-64) = 1.9.1-2.fc27 needed by python-kivy-examples-1.9.1-2.fc27.x86_64
Recommendations:
- Use the %{?python_provide:%python_provide python2-%{srcname}} and %{?python_provide:%python_provide python3-%{srcname}} macros in the python2- and python3- subpackages. This will also make python2-kivy provide python-kivy as it is currently supposed to do. - IMO, example and doc packages don't really need to Require the package they document. You could just drop these requires. This is completely at your option of course, but if you do so, be sure to add the license file to both of them.
* The license on this package is a bit complex according to fedora-review's run of licensecheck. I think the License field should be: LGPLv2.1+, GPLv2+, GPLv3, BSD, and MIT. Additionally, three of the example files are CC by-nc, so the example subpackage further requires that label.
* The Requires are in the top level of the spec file, and only specify python3- requirements. Presumably, the python2- subpackage also needs its versions of these dependencies. The way it's specified, neither subpackage gets its dependencies when installed.
Recommendation:
- Move the python3- dependencies into the python3- %package section, and add python2- equivalents into the python2- %package section.
That's all for requirements to be approved, but I have a few suggestions that are at your option (if you don't do the things after this, it won't block approval of the package):
* The package bundles some fonts. There are a few ways to deal with this:
- These fonts are already packaged for Fedora - you could Require: them and then symlink them.
- You can declare that your package has these fonts bundled by using this syntax:
Provides: bundled(dejavu-sans-fonts) Provides: bundled(google-roboto-fonts)
- Delete the fonts - does it really need them?
* There's a newer version of the package available upstream. According to their home page, 1.10.0 is released.
* Is it possible to run the test suite in Koji? If so, it would be good to add a %check section.
* About 6 MB is being stored in /usr/share. That data could be split into a noarch subpackage that the other packages Require:, which would be nice to do.
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
--- Comment #3 from Randy Barlow randy@electronsweatshop.com --- One more thing - the package fails to build in Koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20228227
The -doc subpackage is requiring an archful version of python-kivy, which is causing it to build differently.
Recommendation:
- Remove the %{_isa} macro from the doc and example package Requires.
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@gmail.com Whiteboard| |AwaitingSubmitter
--- Comment #4 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Ping MartinKG?
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
Petr Viktorin pviktori@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pviktori@redhat.com
--- Comment #5 from Petr Viktorin pviktori@redhat.com --- (In reply to Randy Barlow from comment #2)
Additionally, three of the example files are CC by-nc, so the example subpackage further requires that label.
Note that CC BY-NC is *not* an acceptable licence in Fedora. Examples with restrictions on commercial use need to be removed. See "Bad Licenses" in https://fedoraproject.org/wiki/Licensing:Main#Content_Licenses
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mgansser@online.de
--- Comment #6 from MartinKG mgansser@online.de --- @Petr
this license type are only reported by 3 files from the demo folder, checked by https://martinkg.fedorapeople.org/Packages/kivy/licensecheck.txt
*No copyright* CC by-nc ----------------------- Kivy-1.10.0/examples/demo/showcase/data/icons/next.png Kivy-1.10.0/examples/demo/showcase/data/icons/prev.png Kivy-1.10.0/examples/demo/showcase/data/icons/sourcecode.png
what should we do ? simply remove this files or report it upstream, that thid license type is not accepted by Fedora ?
new RPMS
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-kivy.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-kivy-1.10.0-1.fc28.src...
%changelog * Thu May 24 2018 Martin Gansser martinkg@fedoraproject.org - 1.10.0-1 - Update to 1.10.0 - Add kivy-1.10.0-upstream-cython-fix-1.patch - Add kivy-1.10.0-upstream-cython-fix-2.patch - Add kivy-1.10.0-upstream-cython-fix-3.patch - Add kivy-1.10.0-upstream-cython-fix-4.patch - Add kivy-1.10.0-upstream-cython-fix-5.patch - Add kivy-1.10.0-upstream-sdl-mixer-2.0.2-support.patch - Add kivy-1.10.0-version.patch
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
Petr Viktorin pviktori@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal)
--- Comment #7 from Petr Viktorin pviktori@redhat.com --- Remove the CC-BY-NC files, and let upstream know that these files aren't [Free Content], which is complicating distribution of all of Kivy.
[Free Content]: https://en.wikipedia.org/wiki/Free_content
I am not sure if removing them can be done by simply not including them in the built RPMs, or if you need to remove them from the SRPM as well, as described here: https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohib...
Since I'm not sure, I made the bug block FE-Legal to get someone from the Legal team to clarify.
The section I linked above says "Some upstream packages include patents or trademarks that we are not allowed to ship even as source code," so maybe "Non-Commercial" licenced code is OK to ship in SRPMs? But that reading doesn't sound right -- are there no *licence* restrictions on SRPMs? I couldn't find much in the various guidelines. If there are, I believe the "When Upstream uses Prohibited Code" paragraph should mention/link to them.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@redhat.com Flags|needinfo?(mgansser@alice.de | |) |
--- Comment #8 from Tom "spot" Callaway tcallawa@redhat.com --- Please remove them from the source tarball. It is not sufficient to simply delete these files during the package build process, because the SRPM will have the "No Commercial" restriction, which has an impact on any distribution of Fedora's SRPM tree.
You can ask upstream to remove these non-free files, but they may not be concerned about that.
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
--- Comment #9 from MartinKG mgansser@online.de --- (In reply to Tom "spot" Callaway from comment #8)
Please remove them from the source tarball. It is not sufficient to simply delete these files during the package build process, because the SRPM will have the "No Commercial" restriction, which has an impact on any distribution of Fedora's SRPM tree.
You can ask upstream to remove these non-free files, but they may not be concerned about that.
Thanks for your information
done
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-kivy.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-kivy-1.10.0-2.fc28.src...
%changelog * Fri Jun 08 2018 Martin Gansser martinkg@fedoraproject.org - 1.10.0-2 - remove files with non acceptable CC BY-NC licence from tar archive
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|182235 (FE-Legal) |
--- Comment #10 from Tom "spot" Callaway tcallawa@redhat.com --- Lifting FE-Legal.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
--- Comment #11 from MartinKG mgansser@online.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-kivy.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-kivy-1.10.1-1.fc28.src...
%changelog * Thu Jun 21 2018 Martin Gansser martinkg@fedoraproject.org - 1.10.1-1 - Update to 1.10.1 - Dropped patches - Specfile cleanup
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|AwaitingSubmitter |
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
Randy Barlow rbarlow@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mgansser@alice.de, | |rbarlow@redhat.com Flags| |needinfo?(mgansser@alice.de | |)
--- Comment #12 from Randy Barlow rbarlow@redhat.com --- This seems to fail to build on Rawhide:
cythoning kivy/_event.pyx to kivy/_event.c building 'kivy._event' extension creating build/temp.linux-x86_64-3.7 creating build/temp.linux-x86_64-3.7/kivy gcc -pthread -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -D_GNU_SOURCE -fPIC -fwrapv -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -Ikivy/include -I/usr/include/python3.7m -c kivy/_event.c -o build/temp.linux-x86_64-3.7/kivy/_event.o BUILDSTDERR: /usr/lib64/python3.7/distutils/dist.py:274: UserWarning: Unknown distribution option: 'dependency_links' BUILDSTDERR: warnings.warn(msg) BUILDSTDERR: /usr/lib64/python3.7/distutils/dist.py:274: UserWarning: Unknown distribution option: 'install_requires' BUILDSTDERR: warnings.warn(msg) BUILDSTDERR: /usr/lib64/python3.7/distutils/dist.py:274: UserWarning: Unknown distribution option: 'extra_requires' BUILDSTDERR: warnings.warn(msg) BUILDSTDERR: /usr/lib64/python3.7/distutils/dist.py:274: UserWarning: Unknown distribution option: 'setup_requires' BUILDSTDERR: warnings.warn(msg) BUILDSTDERR: error: command 'gcc' failed with exit status 1
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
--- Comment #13 from MartinKG mgansser@online.de --- I am aware about this issue in rawhide. upstream ticket: https://github.com/kivy/kivy/issues/5936
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
--- Comment #14 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Those are only warnings (possibly because you don't BR setuptools). The build fails because you don't BuildRequires: gcc
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
--- Comment #15 from MartinKG mgansser@online.de --- SRPM URL: https://www.dropbox.com/s/2z8sx3g92jyr7sx/python-kivy-1.10.1-2.fc28.src.rpm?... Spec URL: https://www.dropbox.com/s/rdr8c63oq56kn5m/python-kivy.spec?dl=0
%changelog * Thu Sep 20 2018 Martin Gansser martinkg@fedoraproject.org - 1.10.1-2 - Add BR gcc - Add BR python3-setuptools
https://bugzilla.redhat.com/show_bug.cgi?id=1416705
--- Comment #16 from MartinKG mgansser@online.de --- @Randy
can you please go ahead with the review ?
SRPM URL: https://martinkg.fedorapeople.org/Review/SPECS/python-kivy.spec Spec URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-kivy-1.10.1-2.fc29.src...
%changelog * Thu Sep 20 2018 Martin Gansser martinkg@fedoraproject.org - 1.10.1-2 - Add BR gcc - Add BR python3-setuptools
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla