https://bugzilla.redhat.com/show_bug.cgi?id=1956841
Neal Gompa <ngompa13(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ngompa13(a)gmail.com
--- Comment #11 from Neal Gompa <ngompa13(a)gmail.com> ---
Some review notes as a drive-by reviewer...
BuildRequires: git
Please use "git-core" instead.
BuildRequires: python%{python3_pkgversion}-devel
BuildRequires: python%{python3_pkgversion}-pbr
BuildRequires: python%{python3_pkgversion}-pyxdg >= 0.26
BuildRequires: python%{python3_pkgversion}-requests
BuildRequires: python%{python3_pkgversion}-setuptools
BuildRequires: python%{python3_pkgversion}-toml
BuildRequires: python%{python3_pkgversion}-wheel
This is all redundant since you have a "%generate_buildrequires" section.
Please drop this.
Requires: %{srcname}
Please don't use %srcname here, because this could change names and then it
would break (podman won't change, but this might). Also, this is not listed in
the actual generated subpackage, so this will have no effect. You'll want to
move this to the %package section.
Requires: python%{python3_pkgversion}-pyxdg >= 0.26
Requires: python%{python3_pkgversion}-requests
Requires: python%{python3_pkgversion}-sphinx
Requires: python%{python3_pkgversion}-toml
Requires: python%{python3_pkgversion}-urllib3 >= 1.24.2
Requires: python%{python3_pkgversion}-wheel
This is all unnecessary, since the dependencies are autogenerated. Please drop
it.
Provides: python%{python3_pkgversion}-%{pypi_name} =
%{version}-%{release}
Provides: %{pypi_name}-py = %{version}-%{release}
Provides: python%{python3_pkgversion}-%{pypi_name}-py = %{version}-%{release}
This is not listed in the actual generated subpackage, so this will have no
effect. You'll want to move this to the %package section.
%prep
%autosetup -Sgit -n %{srcname}-py-%{version}
%generate_buildrequires
%pyproject_buildrequires %{?with_tests:-t}
Please put a newline between the %autosetup and %generate_buildrequires lines,
because they are separate spec sections. You may also want to use "-S git_am"
for patch application instead of "-Sgit".
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component