https://bugzilla.redhat.com/show_bug.cgi?id=1262515
Bug ID: 1262515 Summary: Review Request: qbs - Qt Build Suite Product: Fedora Version: rawhide Component: Package Review Severity: high Assignee: nobody@fedoraproject.org Reporter: jake.petroules@petroules.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
I am taking over the qbs submission from Erik Schilling. Continued from https://bugzilla.redhat.com/show_bug.cgi?id=979124
Spec URL: https://raw.githubusercontent.com/jakepetroules/spec-qbs/1.4/qbs.spec SRPM URL: (coming soon)
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |928937 (qt-reviews) CC| |ablu.erikschilling@googlema | |il.com
--- Comment #1 from Raphael Groner projects.rg@smart.ms --- *** Bug 979124 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
Erik Schilling ablu.erikschilling@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tigcc.ticalc.org Alias| |qbs
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #2 from Jake Petroules jake.petroules@petroules.com --- Spec URL: https://raw.githubusercontent.com/jakepetroules/spec-qbs/1.4/qbs.spec SRPM URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=11070463
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #3 from Erik Schilling ablu.erikschilling@googlemail.com --- Please upload your SRPM to a place which is accessible with a direct wget call. That allows tools like fedora-review (https://fedorahosted.org/FedoraReview/) to automatically detect the SRPM. Also you cannot download the SRPM from koji after the build is done. And the spec file alone is not enough since patches and sources are not included there.
The SRPM is a package which basically contains the .spec file together with all its dependencies (sources and patches mainly).
Regards, Erik
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #4 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- jakepetroules's scratch build of qbs-1.4.2-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11248240
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #5 from Jake Petroules jake.petroules@petroules.com --- Spec URL: https://raw.githubusercontent.com/jakepetroules/spec-qbs/1.4/qbs.spec SRPM URL: https://raw.githubusercontent.com/jakepetroules/spec-qbs/1.4/qbs-1.4.2-1.fc2... Fedora Account System Username: jakepetroules koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=11248240
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #6 from Jake Petroules jake.petroules@petroules.com --- So, how can we start moving this review process forward? This has already been in the works since 2012 or 2013 and I'd really like to get things moving.
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #7 from Raphael Groner projects.rg@smart.ms --- Generally, you can get sponsored into the packager group when you comment at some package reviews by yourself or become a co-maintainer of an existing package. https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
Unfortunately, I can not sponsor you. Though are you interested in mono package reviews - besides Qt stuff?
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #8 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- jakepetroules's scratch build of qbs-1.4.2-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11578571
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #9 from Jake Petroules jake.petroules@petroules.com --- Raphael, I already have too much on my plate to get involved with the Mono package reviews.
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #10 from Jake Petroules jake.petroules@petroules.com --- Updated URLs:
Spec URL: https://raw.githubusercontent.com/jakepetroules/spec-qbs/1.4/SPECS/qbs.spec SRPM URL: https://raw.githubusercontent.com/jakepetroules/spec-qbs/1.4/SRPMS/qbs-1.4.2...
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #11 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- jakepetroules's scratch build of qbs-1.4.2-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11578581
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #12 from Michael Schwendt bugs.michael@gmx.net --- (!) 404 not found for the src.rpm
# Required for running the tests BuildRequires: pkgconfig(Qt5Quick) BuildRequires: glibc-static BuildRequires: libstdc++-static
Hmmm. Does the comment above that also refer to the two -static packages?
Why would tests require linking statically?
Since BuildRequires apply to the entire package, the availability of the static libs in the buildroot can be problematic due to linking other executables statically (either accidentally, unknowingly or because of build defaults changing eventually). That would be something to avoid by adding guards or finding ways to eliminate static linking in those tests.
https://fedoraproject.org/wiki/Packaging:Guidelines#Statically_Linking_Execu...
[...]
Has "fedora-review -b 1262515" been run for this ticket yet?
[...]
%package doc %package examples
If these shall stay completely separate subpackages, consider fixing the directory ownership and %license usage for these packages.
* https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text * https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_b...
https://bugzilla.redhat.com/show_bug.cgi?id=1262515
--- Comment #13 from Erik Schilling ablu.erikschilling@googlemail.com --- QBS unfortunately is deprecated now (https://blog.qt.io/blog/2018/10/29/deprecation-of-qbs/)
package-review@lists.fedoraproject.org