[Bug 508849] New: Review Request: perl-POE-Component-Server-Bayeux - Bayeux/cometd server implementation in POE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-POE-Component-Server-Bayeux - Bayeux/cometd server implementation in POE
https://bugzilla.redhat.com/show_bug.cgi?id=508849
Summary: Review Request: perl-POE-Component-Server-Bayeux - Bayeux/cometd server implementation in POE Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: yaneti@declera.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://declera.com/~yaneti/perl-POE-Component-Server-Bayeux/perl-POE-Compone... SRPM URL: http://declera.com/~yaneti/perl-POE-Component-Server-Bayeux/perl-POE-Compone... Description: This module implements the Bayeux Protocol (1.0draft1) from the Dojo Foundation. Also called cometd, Bayeux is a low-latency routing protocol for JSON encoded events between clients and servers in a publish- subscribe model.
$ rpmlint mock/fedora-rawhide-x86_64/result/perl-POE-Component-Server-Bayeux-0.02-1.fc12.*.rpm mock/fedora-10-i386/result/perl-POE-Component-Server-Bayeux-0.02-1.fc10.*.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508849
Jochen Schmitt jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@herr-schmitt.de AssignedTo|nobody@fedoraproject.org |jochen@herr-schmitt.de Flag| |fedora-review+
--- Comment #1 from Jochen Schmitt jochen@herr-schmitt.de 2009-06-30 15:26:52 EDT --- Good: + Basename of SPEC files matches with package name + Package name fullfill naming guidelines + URL tag shows on proper project homepage + Could download upstream sources via spectool -g + Package source tar ball matches with upstream (md5sum: dd18ab3f61f390fbc96a8dc8a15aa447) * Package has proper License tag + License Tag says GPLv2 and Artistic as OSS license * Copyright note in the source files matches with license tag + Package has proper Buildroot definition + Consistently usage of rpm macros + Proper Buildroot definition + BuidRoot will be clean at the beginning of %clean and %install + Package will be built for noarch * Local build works fine + Package has a %check stanza + Rpmlint is quite for source rpm + rpmlint is quite for binary rpm + Scratch build on koji works fine + Local install and uninstall works fine + %doc stanza is small, no extra subpackage in required + Files has proper files permission + %files contains no duplicated entries + All packaged files are owned by this package + No packaged files belong to another package + package has proper Changelog
Bad: - Package doesn't contains verbain copy of the license (no blocker)
** APPROVED **
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508849
Yanko Kaneti yaneti@declera.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Yanko Kaneti yaneti@declera.com 2009-06-30 17:18:20 EDT --- New Package CVS Request ======================= Package Name: perl-POE-Component-Server-Bayeux Short Description: Bayeux/cometd server implementation in POE Owners: yaneti Branches: F-10 F-11 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508849
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2009-06-30 22:44:17 EDT --- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=508849
Yanko Kaneti yaneti@declera.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #4 from Yanko Kaneti yaneti@declera.com 2009-07-01 01:39:22 EDT --- Imported. Builds done. Bodhi updates pending. Thanks for the review.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla