https://bugzilla.redhat.com/show_bug.cgi?id=2138425
Kalev Lember <klember(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Doc Type|--- |If docs needed, set a value
Flags| |fedora-review+
Assignee|nobody(a)fedoraproject.org |klember(a)redhat.com
CC| |klember(a)redhat.com
--- Comment #1 from Kalev Lember <klember(a)redhat.com> ---
Fedora review rust-tokio-uring-0.3.0-1.fc37.src.rpm 2022-11-16
$ rpmlint rust-tokio-uring-0.3.0-1.fc37.src.rpm \
rust-tokio-uring+default-devel-0.3.0-1.fc38.noarch.rpm \
rust-tokio-uring+bytes-devel-0.3.0-1.fc38.noarch.rpm \
rust-tokio-uring-devel-0.3.0-1.fc38.noarch.rpm
===================================================================================
rpmlint session starts
===================================================================================
rpmlint: 2.2.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4
rust-tokio-uring-devel.noarch: E: zero-length
/usr/share/cargo/registry/tokio-uring-0.3.0/src/driver/bind.rs
rust-tokio-uring+bytes-devel.noarch: W: no-documentation
rust-tokio-uring+default-devel.noarch: W: no-documentation
==================================================== 4 packages and 0 specfiles
checked; 1 errors, 2 warnings, 1 badness; has taken 0.1 s
====================================================
+ OK
! needs attention
+ rpmlint output looks good
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (MIT) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
SHA512 (tokio-uring-0.3.0.crate) =
9c5262459be86c950b306ce7c999acfa42d6dcdd1de61ad7399d87a34106e9e7bc77b316d1071da0fc67763057acbef5acd735202e6472e39f7c210dc14afc99
SHA512 (Download/tokio-uring-0.3.0.crate) =
9c5262459be86c950b306ce7c999acfa42d6dcdd1de61ad7399d87a34106e9e7bc77b316d1071da0fc67763057acbef5acd735202e6472e39f7c210dc14afc99
+ Package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files (LICENSE, CHANGELOG.md, README.md are listed
twice but that's expected with the rust2rpm generator)
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8
+ Package does not depend on deprecated packages
Everything looks nice and clean to me. One thing that I noticed is that
upstream just released 0.4.0 if you want to update it to the latest version.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2138425