Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=505928
Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody(a)fedoraproject.org |mtasaka(a)ioa.s.u-tokyo.ac.jp
Flag| |fedora-review?
--- Comment #7 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> 2009-07-16 10:18:20
EDT ---
Well, for -2:
* SourceURL
- For
sourceforge.net hosted URL, follow:
https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
* $RPM_BUILD_ROOTvs %buildroot
- Please choose one and don't use both.
* Installing %SOURCE{1,2,3}
---------------------------------------------------
cp %SOURCE1 .
...
...
cp -p hdapsd.event %{buildroot}%{_sysconfdir}/event.d/hdapsd
---------------------------------------------------
- This can simply be:
---------------------------------------------------
cp -p %SOURCE1 %{buildroot}%{_sysconfdir}/event.d/hdapsd
---------------------------------------------------
* Document installation path
- By default Fedora installs document files under
%{_defaultdocdir}/%{name}-%{version}. I suggest to once
remove all files under %{_defaultdocdir}/%{name} and
use %doc as:
---------------------------------------------------
%install
rm -rf %{buildroot}
....
make install DESTDIR=%{buildroot}
....
rm -rf %{buildroot}%{_defaultdocdir}/%{name}
....
....
%files
%doc AUTHORS
%doc COPYING
%doc ChangeLog
%doc README
....
--------------------------------------------------
! By the way installing "COPYING" file is rather mandatory
if it exists.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.