Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-hi - Hindi hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=427508
tibbs(a)math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs(a)math.uh.edu 2008-01-05 17:31 EST -------
As with the other package, you should include the Copyright file as %doc.
That's the only issue I see, so I'll go ahead and approve this and you can fix
it when you check in.
* source files match upstream:
2e78f20096dfa254fe92ea7cf6ec3ed19cdf664e68eea964c56651c8e79e8345
hi-demo.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
hunspell-hi = 20050726-1.fc9
=
hunspell
* %check is not present; I don't know any Hindi so I cannot test this.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* acceptable content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.