https://bugzilla.redhat.com/show_bug.cgi?id=1420124

--- Comment #1 from Ralph Bean rbean@redhat.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17658617

https://bugzilla.redhat.com/show_bug.cgi?id=1420124

--- Comment #2 from Dan Callaghan dcallagh@redhat.com --- You could switch the upstream source URL to pull from Github instead of PyPI -- that would solve the lack of license text and also missing tests.

What do you think?

https://bugzilla.redhat.com/show_bug.cgi?id=1420124

Dan Callaghan dcallagh@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+

--- Comment #4 from Dan Callaghan dcallagh@redhat.com --- Consider escaping the commented-out %license macro to keep rpmlint happy.

APPROVED

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. [-]: License file installed when any subpackage combination is installed. Upstream doesn't ship a copy of the license, PR filed. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: python2-django-rest-framework-composed-permissions-0.1-2.fc26.noarch.rpm

python3-django-rest-framework-composed-permissions-0.1-2.fc26.noarch.rpm python-django-rest-framework-composed-permissions-0.1-2.fc26.src.rpm python2-django-rest-framework-composed-permissions.noarch: E: zero-length /usr/lib/python2.7/site-packages/restfw_composed_permissions/models.py python3-django-rest-framework-composed-permissions.noarch: E: zero-length /usr/lib/python3.6/site-packages/restfw_composed_permissions/models.py python-django-rest-framework-composed-permissions.src:94: W: macro-in-comment %license python-django-rest-framework-composed-permissions.src:103: W: macro-in-comment %license 3 packages and 0 specfiles checked; 2 errors, 2 warnings.

Rpmlint (installed packages) ---------------------------- python2-django-rest-framework-composed-permissions.noarch: E: zero-length /usr/lib/python2.7/site-packages/restfw_composed_permissions/models.py python3-django-rest-framework-composed-permissions.noarch: E: zero-length /usr/lib/python3.6/site-packages/restfw_composed_permissions/models.py 2 packages and 0 specfiles checked; 2 errors, 0 warnings.

Requires -------- python2-django-rest-framework-composed-permissions (rpmlib, GLIBC filtered): python(abi) python-django-rest-framework python2-django

python3-django-rest-framework-composed-permissions (rpmlib, GLIBC filtered): python(abi) python3-django python3-django-rest-framework

Provides -------- python2-django-rest-framework-composed-permissions: python-django-rest-framework-composed-permissions python2-django-rest-framework-composed-permissions python2.7dist(djangorestframework-composed-permissions) python2dist(djangorestframework-composed-permissions)

python3-django-rest-framework-composed-permissions: python3-django-rest-framework-composed-permissions python3.6dist(djangorestframework-composed-permissions) python3dist(djangorestframework-composed-permissions)

Source checksums ---------------- https://pypi.io/packages/source/d/djangorestframework-composed-permissions/d... : CHECKSUM(SHA256) this package : eb1595e5f001a14d4711e7813f812c76ebddc23249c477b2e3fae2140abedf06 CHECKSUM(SHA256) upstream package : eb1595e5f001a14d4711e7813f812c76ebddc23249c477b2e3fae2140abedf06

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1420124 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

https://bugzilla.redhat.com/show_bug.cgi?id=1420124

--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-django-rest-framework-composed-permissions-0.1-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d1924ccb7d

https://bugzilla.redhat.com/show_bug.cgi?id=1420124

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-django-rest-framework-composed-permissions-0.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d1924ccb7d