https://bugzilla.redhat.com/show_bug.cgi?id=1321449
Marek Cermak <macermak(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #6 from Marek Cermak <macermak(a)redhat.com> ---
Initial fedora-review output
============================
+ py.test-2 -v tests/
============================= test session starts
==============================
platform linux2 -- Python 2.7.13, pytest-3.1.1, py-1.4.34, pluggy-0.4.0 --
/usr/bin/python2
tests/test_forwarder.py::SSHClientTest::test_connect_via_proxy FAILED
ts/test_forwarder.py::SSHClientTest::test_deprecate_warnings_are_shown FAILED
tests/test_forwarder.py::AuxiliaryTest::test_read_ssh_config FAILED
============================= FAILURES ===================================
_____________________ SSHClientTest.test_connect_via_proxy
_____________________
E OSError: [Errno 2] No such file or directory
/usr/lib64/python2.7/subprocess.py:1024: OSError
_______________ SSHClientTest.test_deprecate_warnings_are_shown
________________
E IndexError: list index out of range
tests/test_forwarder.py:656: IndexError
______________________ AuxiliaryTest.test_read_ssh_config
______________________
E AssertionError: None is not true
tests/test_forwarder.py:1183: AssertionError
=============== 3 failed, 40 passed, 1 xpassed in 20.43 seconds
================
+ py.test-3 -v tests/
============================= test session starts
==============================
platform linux -- Python 3.6.1, pytest-3.1.1, py-1.4.34, pluggy-0.4.0 --
/usr/bin/python3
tests/test_forwarder.py::SSHClientTest::test_connect_via_proxy FAILED
tests/test_forwarder.py::SSHClientTest::test_gateway_ip_unresolvable_raises_exception
FAILED
tests/test_forwarder.py::AuxiliaryTest::test_read_ssh_config FAILED
=================================== FAILURES
===================================
_____________________ SSHClientTest.test_connect_via_proxy
_____________________
E FileNotFoundError: [Errno 2] No such file or directory: 'ssh'
/usr/lib64/python3.6/subprocess.py:1326: FileNotFoundError
_________ SSHClientTest.test_gateway_ip_unresolvable_raises_exception
__________
Unexpected success
______________________ AuxiliaryTest.test_read_ssh_config
______________________
E AssertionError: None is not true
tests/test_forwarder.py:1183: AssertionError
===================== 3 failed, 41 passed in 15.79 seconds
=====================
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.Py7mcD (%check)
Bad exit status from /var/tmp/rpm-tmp.Py7mcD (%check)
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/mockbuild/trace_decorator.py", line
96, in trace
result = func(*args, **kw)
File "/usr/lib/python3.6/site-packages/mockbuild/util.py", line 590, in do
raise exception.Error("Command failed: \n # %s\n%s" % (command, output),
child.returncode)
mockbuild.exception.Error: Command failed:
# /usr/bin/systemd-nspawn -q -M eea7d073d1694b8093e8b911268aa8b6 -D
/var/lib/mock/fedora-rawhide-x86_64/root -a --private-network
--setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir
--setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin
--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"
--setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=en_US.UTF-8 -u mockbuild bash
--login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps
/builddir/build/SPECS/python-sshtunnel.spec
---------------------------------------------------------
Modified spec file to bypass %check errors in such manner that:
=========================================================
$ diff python-sshtunnel.spec.old python-sshtunnel.spec
63c63
< py.test-3 -v tests/
---
py.test-3 -v tests/ || :
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 20 files
have
unknown license. Detailed output of licensecheck in
/home/macermak/RedHat/Fedora/Reviews/1321449/review-python-
sshtunnel/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python2-sshtunnel , python3-sshtunnel
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python2-sshtunnel-0.0.8.1-1.fc27.noarch.rpm
python3-sshtunnel-0.0.8.1-1.fc27.noarch.rpm
python-sshtunnel-0.0.8.1-1.fc27.src.rpm
python-sshtunnel.spec
python2-sshtunnel.noarch: W: no-documentation
python2-sshtunnel.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/sshtunnel.py /usr/bin/env python
python2-sshtunnel.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/sshtunnel.py 644 /usr/bin/env python
python3-sshtunnel.noarch: W: no-documentation
python3-sshtunnel.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/sshtunnel.py /usr/bin/env python
python3-sshtunnel.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/sshtunnel.py 644 /usr/bin/env python
python3-sshtunnel.noarch: W: no-manual-page-for-binary sshtunnel
3 packages and 1 specfiles checked; 4 errors, 3 warnings.
Rpmlint (installed packages)
----------------------------
python2-sshtunnel.noarch: W: no-documentation
python2-sshtunnel.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/sshtunnel.py /usr/bin/env python
python2-sshtunnel.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/sshtunnel.py 644 /usr/bin/env python
python3-sshtunnel.noarch: W: no-documentation
python3-sshtunnel.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/sshtunnel.py /usr/bin/env python
python3-sshtunnel.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/sshtunnel.py 644 /usr/bin/env python
python3-sshtunnel.noarch: W: no-manual-page-for-binary sshtunnel
2 packages and 0 specfiles checked; 4 errors, 3 warnings.
Requires
--------
python2-sshtunnel (rpmlib, GLIBC filtered):
python(abi)
python2-paramiko
python3-sshtunnel (rpmlib, GLIBC filtered):
/usr/bin/python3
python(abi)
python3-paramiko
Provides
--------
python2-sshtunnel:
python-sshtunnel
python2-sshtunnel
python2.7dist(sshtunnel)
python2dist(sshtunnel)
python3-sshtunnel:
python3-sshtunnel
python3.6dist(sshtunnel)
python3dist(sshtunnel)
Licensecheck
------------
MIT/X11 (BSD like)
------------------
sshtunnel-0.0.8.1/LICENSE
Unknown or generated
--------------------
sshtunnel-0.0.8.1/.travis.yml
sshtunnel-0.0.8.1/MANIFEST.in
sshtunnel-0.0.8.1/README.rst
sshtunnel-0.0.8.1/appveyor.yml
sshtunnel-0.0.8.1/changelog.rst
sshtunnel-0.0.8.1/circle.yml
sshtunnel-0.0.8.1/docs.rst
sshtunnel-0.0.8.1/docs/Makefile
sshtunnel-0.0.8.1/docs/conf.py
sshtunnel-0.0.8.1/docs/index.rst
sshtunnel-0.0.8.1/docs/requirements-docs.txt
sshtunnel-0.0.8.1/setup.cfg
sshtunnel-0.0.8.1/setup.py
sshtunnel-0.0.8.1/sshtunnel.py
sshtunnel-0.0.8.1/tests/__init__.py
sshtunnel-0.0.8.1/tests/test_forwarder.py
sshtunnel-0.0.8.1/tests/testconfig
sshtunnel-0.0.8.1/tests/testrsa.key
sshtunnel-0.0.8.1/tests/testrsa_encrypted.key
sshtunnel-0.0.8.1/tox.ini
Source checksums
----------------
https://github.com/pahaz/sshtunnel/archive/0.0.8.1/sshtunnel-0.0.8.1.tar.gz :
CHECKSUM(SHA256) this package :
289662412174c9786f1ae1d76793568153dae66260d827ea8323ddd19502232c
CHECKSUM(SHA256) upstream package :
289662412174c9786f1ae1d76793568153dae66260d827ea8323ddd19502232c
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -n python-sshtunnel
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
----------------------------------------------------
Notes :
Latest tag on:
https://github.com/pahaz/sshtunnel/tags - 0.1.2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component