https://bugzilla.redhat.com/show_bug.cgi?id=2259274
Bug ID: 2259274 Summary: Review Request: golang-github-stoicperlman-fls - Go File Line Seeker Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: arthur@bols.dev QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://principis.fedorapeople.org/golang-github-stoicperlman-fls.spec SRPM URL: https://principis.fedorapeople.org/golang-github-stoicperlman-fls-0-0.1.2024... Description: Go File Line Seeker. Fedora Account System Username: principis
https://bugzilla.redhat.com/show_bug.cgi?id=2259274
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6923263 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2259274
Arthur Bols arthur@bols.dev changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Arthur Bols arthur@bols.dev --- Recreated spec with go2rpm 1.11.0.
Spec URL: https://principis.fedorapeople.org/golang-github-stoicperlman-fls.spec SRPM URL: https://principis.fedorapeople.org/golang-github-stoicperlman-fls-0-0.1.2024...
https://bugzilla.redhat.com/show_bug.cgi?id=2259274
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2021000 --> https://bugzilla.redhat.com/attachment.cgi?id=2021000&action=edit The .spec file difference from Copr build 6923263 to 7132016
https://bugzilla.redhat.com/show_bug.cgi?id=2259274
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|AutomationTriaged |
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7132016 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2259274
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@olasagasti.info Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |mikel@olasagasti.info
--- Comment #5 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Golang Package Review ==============
This package was generated using go2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2259274
Arthur Bols arthur@bols.dev changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2024-07-27 14:08:15
--- Comment #6 from Arthur Bols arthur@bols.dev --- Sorry for missing the review and thanks for the effort. I'm abandoning this for now.
package-review@lists.fedoraproject.org