https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Bug ID: 2295805 Summary: Review Request: rust-derive-into-owned - Custom derives to help with types containing Cow fields Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: atenart@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/retis-org/copr-playground/blob/main/rust-derive-into-owne... SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-... Description: Custom derives to help with types containing Cow fields Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7671849/
Fedora Account System Username: atenart, pvaler, amorenoz
I’m starting this review request on behalf of Paolo, Adrián and me. We’d like to maintain it as a group. It’s our first package and we’ll need a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://crates.io/crates/de | |rive-into-owned
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7708108 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Paolo Valerio pvalerio@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2295815
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2295815 [Bug 2295815] Review Request: rust-pcap-file - A crate to parse, read and write Pcap and PcapNg
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Please provide URLs to raw files, not HTML pages. Otherwise tooling will not be able to parse this ticket.
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Antoine Tenart atenart@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-derive... SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-... Description: Custom derives to help with types containing Cow fields Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7671849/
Fedora Account System Username: atenart, pvaler, amorenoz
I’m starting this review request on behalf of Paolo, Adrián and me. We’d like to maintain it as a group. It’s our first package and we’ll need a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7773647 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #5 from Fabio Valentini decathorpe@gmail.com ---
# FIXME: no license files detected
It looks like you used "rust2rpm --ignore-missing-license-files" *and* didn't actually fix the FIXME? The MIT license requires that redistributed sources contain a copy of the license text.
It looks like the upstream project added a license file after publishing the latest release: https://github.com/koivunej/derive-into-owned
Please file an issue upstream about getting a new release that contains the license text. In the meantime, you can include the license file from GitHub as a separate source.
For Rust packages, we usually handle this case like it is handled here: https://src.fedoraproject.org/rpms/rust-backtrace-ext/blob/rawhide/f/rust-ba...
(except that you only have one LICENSE file instead of LICENSE-APACHE and LICENSE-MIT, of course)
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Paolo Valerio pvalerio@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-derive... SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-... Description: Custom derives to help with types containing Cow fields Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/07884763
Fedora Account System Username: atenart, pvaler, amorenoz
I’m starting this review request on behalf of Paolo, Adrián and me. We’d like to maintain it as a group. It’s our first package and we’ll need a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
--- Comment #6 from Paolo Valerio pvalerio@redhat.com --- Thanks for the feedback. The spec file has been updated as per your suggestion including the license file as a separate source. An issue [1] has been filed requesting a new release and both SRPM URL and Build links have been updated in the BZ description to reference the latest build.
[1] https://github.com/koivunej/derive-into-owned/issues/19
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
--- Comment #8 from Fabio Valentini decathorpe@gmail.com --- Thanks for adding the file as an additional source and filing an issue upstream. However, the file is now just unused in the package. You still need to put it into the correct place and mark it as a license file:
- do something equivalent to `cp %{SOURCE1} .` at the end of the %prep scriptlet (i.e. after the %cargo_prep line) - add this line at the start of the %files list for the "devel" subpackage: `%license %{crate_instdir}/LICENSE`
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
--- Comment #9 from Paolo Valerio pvalerio@redhat.com --- argh, I missed those, sorry about it. Now the license file should be copied and marked.
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-derive... SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-...
Description: Custom derives to help with types containing Cow fields Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7953228/
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #10 from Fabio Valentini decathorpe@gmail.com --- Thank you, looks good to me now!
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files (termporarily manually included from upstream) ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
===
If you need help with any of the following steps, feel free to reach out on the #rust channel on the Fedora Matrix homeserver.
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #11 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-derive-into-owned
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-8af107498b (rust-derive-into-owned-0.2.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8af107498b
https://bugzilla.redhat.com/show_bug.cgi?id=2295805
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-10-15 15:07:10
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-8af107498b (rust-derive-into-owned-0.2.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org